[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Javi Merino]

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
DT.  However, this makes the kernel fail to boot on the arndale-octa
spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral

And eventually hangs.  Without the vmmc-supply property in the
mmc at 12220000 node, the kernel boots again.

Signed-off-by: Javi Merino <javi.merino@arm.com>
---

Hi,

Note that I don't know *why* removing the property works, all I know
is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this
patch.

Cheers,
Javi

 arch/arm/boot/dts/exynos5420-arndale-octa.dts |    1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 80a3bf4..722fb6c 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -64,7 +64,6 @@
 		samsung,dw-mshc-ddr-timing = <1 2>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
-		vmmc-supply = <&ldo10_reg>;
 
 		slot at 0 {
 			reg = <0>;
-- 
1.7.9.5

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Tomasz Figa]

Hi Javi,

On 25.04.2014 22:11, Javi Merino wrote:
> d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
> added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
> DT.  However, this makes the kernel fail to boot on the arndale-octa
> spews:
>
> [    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
> [    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
> [    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
> [    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral
>
> And eventually hangs.  Without the vmmc-supply property in the
> mmc at 12220000 node, the kernel boots again.
>
> Signed-off-by: Javi Merino <javi.merino@arm.com>
> ---
>
> Hi,
>
> Note that I don't know *why* removing the property works, all I know
> is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this
> patch.

Are you sure you have the required PMIC driver enabled in your kernel 
config?

Best regards,
Tomasz

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Javi Merino]

On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote:
> Hi Javi,
> 
> On 25.04.2014 22:11, Javi Merino wrote:
> > d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
> > added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
> > DT.  However, this makes the kernel fail to boot on the arndale-octa
> > spews:
> >
> > [    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
> > [    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
> > [    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
> > [    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral
> >
> > And eventually hangs.  Without the vmmc-supply property in the
> > mmc at 12220000 node, the kernel boots again.
> >
> > Signed-off-by: Javi Merino <javi.merino@arm.com>
> > ---
> >
> > Hi,
> >
> > Note that I don't know *why* removing the property works, all I know
> > is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this
> > patch.
> 
> Are you sure you have the required PMIC driver enabled in your kernel 
> config?

I configured the kernel using exynos_defconfig and that gives me:

# CONFIG_PMIC_ADP5520 is not set
# CONFIG_PMIC_DA903X is not set

Should I be using other defconfig for this board?  exynos_defconfig
used to work in 3.14.  Cheers,
Javi

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Tomasz Figa]

On 25.04.2014 22:30, Javi Merino wrote:
> On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote:
>> Hi Javi,
>>
>> On 25.04.2014 22:11, Javi Merino wrote:
>>> d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
>>> added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
>>> DT.  However, this makes the kernel fail to boot on the arndale-octa
>>> spews:
>>>
>>> [    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
>>> [    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
>>> [    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
>>> [    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral
>>>
>>> And eventually hangs.  Without the vmmc-supply property in the
>>> mmc at 12220000 node, the kernel boots again.
>>>
>>> Signed-off-by: Javi Merino <javi.merino@arm.com>
>>> ---
>>>
>>> Hi,
>>>
>>> Note that I don't know *why* removing the property works, all I know
>>> is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this
>>> patch.
>>
>> Are you sure you have the required PMIC driver enabled in your kernel
>> config?
>
> I configured the kernel using exynos_defconfig and that gives me:
>
> # CONFIG_PMIC_ADP5520 is not set
> # CONFIG_PMIC_DA903X is not set
>
> Should I be using other defconfig for this board?  exynos_defconfig
> used to work in 3.14.  Cheers,

Well, unfortunately exynos_defconfig is known to be far from being 
reasonable. Right now it should be considered just as a base to 
configure the kernel for Exynos SoCs. Most of board specific options 
(and many of SoC-wide ones) need to be selected manually.

Anyway, with the number of Exynos boards supported in mainline, I don't 
think we will be ever going to enable all options for all the supported 
boards by default in defconfig, especially considering the fact that we 
will be moving to generic multi_v7_defconfig and likely dropping 
exynos_defconfig completely.

As for now, I believe you should just make sure yourself that any 
options relevant to your board are enabled.

Best regards,
Tomasz

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Javi Merino]

On Fri, Apr 25, 2014 at 09:35:35PM +0100, Tomasz Figa wrote:
> On 25.04.2014 22:30, Javi Merino wrote:
> > On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote:
> >> On 25.04.2014 22:11, Javi Merino wrote:
> >>> d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
> >>> added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
> >>> DT.  However, this makes the kernel fail to boot on the arndale-octa
> >>> spews:
> >>>
> >>> [    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
> >>> [    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
> >>> [    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
> >>> [    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral
> >>>
> >>> And eventually hangs.  Without the vmmc-supply property in the
> >>> mmc at 12220000 node, the kernel boots again.
> >>>
> >>> Signed-off-by: Javi Merino <javi.merino@arm.com>
> >>> ---
> >>>
> >>> Hi,
> >>>
> >>> Note that I don't know *why* removing the property works, all I know
> >>> is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this
> >>> patch.
> >>
> >> Are you sure you have the required PMIC driver enabled in your kernel
> >> config?
> >
> > I configured the kernel using exynos_defconfig and that gives me:
> >
> > # CONFIG_PMIC_ADP5520 is not set
> > # CONFIG_PMIC_DA903X is not set
> >
> > Should I be using other defconfig for this board?  exynos_defconfig
> > used to work in 3.14.  Cheers,
> 
> Well, unfortunately exynos_defconfig is known to be far from being 
> reasonable. Right now it should be considered just as a base to 
> configure the kernel for Exynos SoCs. Most of board specific options 
> (and many of SoC-wide ones) need to be selected manually.
> 
> Anyway, with the number of Exynos boards supported in mainline, I don't 
> think we will be ever going to enable all options for all the supported 
> boards by default in defconfig, especially considering the fact that we 
> will be moving to generic multi_v7_defconfig and likely dropping 
> exynos_defconfig completely.
> 
> As for now, I believe you should just make sure yourself that any 
> options relevant to your board are enabled.

Great.  And I assume that there isn't a list of those options in the
web.  So how do I know what options are relevant to my board?  By
sending emails to linux-samsung-soc whenever it fails to boot?

Cheers,
Javi

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Kukjin Kim]

Javi Merino wrote:
> 
> On Fri, Apr 25, 2014 at 09:35:35PM +0100, Tomasz Figa wrote:
> > On 25.04.2014 22:30, Javi Merino wrote:
> > > On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote:
> > >> On 25.04.2014 22:11, Javi Merino wrote:
> > >>> d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
> > >>> added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
> > >>> DT.  However, this makes the kernel fail to boot on the arndale-octa
> > >>> spews:
> > >>>
> > >>> [    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not
> found, assuming 1 slot is available
> > >>> [    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests
> probe deferral
> > >>> [    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not
> found, assuming 1 slot is available
> > >>> [    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests
> probe deferral
> > >>>
> > >>> And eventually hangs.  Without the vmmc-supply property in the
> > >>> mmc at 12220000 node, the kernel boots again.
> > >>>
> > >>> Signed-off-by: Javi Merino <javi.merino@arm.com>
> > >>> ---
> > >>>
> > >>> Hi,
> > >>>
> > >>> Note that I don't know *why* removing the property works, all I know
> > >>> is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply
> this
> > >>> patch.
> > >>
> > >> Are you sure you have the required PMIC driver enabled in your kernel
> > >> config?
> > >
> > > I configured the kernel using exynos_defconfig and that gives me:
> > >
> > > # CONFIG_PMIC_ADP5520 is not set
> > > # CONFIG_PMIC_DA903X is not set
> > >
> > > Should I be using other defconfig for this board?  exynos_defconfig
> > > used to work in 3.14.  Cheers,
> >
> > Well, unfortunately exynos_defconfig is known to be far from being
> > reasonable. Right now it should be considered just as a base to
> > configure the kernel for Exynos SoCs. Most of board specific options
> > (and many of SoC-wide ones) need to be selected manually.
> >
> > Anyway, with the number of Exynos boards supported in mainline, I don't
> > think we will be ever going to enable all options for all the supported
> > boards by default in defconfig, especially considering the fact that we
> > will be moving to generic multi_v7_defconfig and likely dropping
> > exynos_defconfig completely.

Well, keeping exynos_defconfig would be helpful even if exynos multiplatform is available. Please see the case of omap2plus_defconfig?

> >
> > As for now, I believe you should just make sure yourself that any
> > options relevant to your board are enabled.
> 
> Great.  And I assume that there isn't a list of those options in the
> web.  So how do I know what options are relevant to my board?  By
> sending emails to linux-samsung-soc whenever it fails to boot?
> 
I think, we need to enable all of regarding configs for each exynos boards so that exynos_defconfig can cover whenever.

Thanks,
Kukjin

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Sachin Kamat]

Hi Javi,

On 26 April 2014 16:49, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Javi Merino wrote:
>>
>> On Fri, Apr 25, 2014 at 09:35:35PM +0100, Tomasz Figa wrote:
>> > On 25.04.2014 22:30, Javi Merino wrote:
>> > > On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote:
>> > >> On 25.04.2014 22:11, Javi Merino wrote:
>> > >>> d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
>> > >>> added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
>> > >>> DT.  However, this makes the kernel fail to boot on the arndale-octa
>> > >>> spews:
>> > >>>
>> > >>> [    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not
>> found, assuming 1 slot is available
>> > >>> [    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests
>> probe deferral
>> > >>> [    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not
>> found, assuming 1 slot is available
>> > >>> [    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests
>> probe deferral
>> > >>>
>> > >>> And eventually hangs.  Without the vmmc-supply property in the
>> > >>> mmc at 12220000 node, the kernel boots again.
>> > >>>
>> > >>> Signed-off-by: Javi Merino <javi.merino@arm.com>
>> > >>> ---
>> > >>>
>> > >>> Hi,
>> > >>>
>> > >>> Note that I don't know *why* removing the property works, all I know
>> > >>> is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply
>> this
>> > >>> patch.
>> > >>
>> > >> Are you sure you have the required PMIC driver enabled in your kernel
>> > >> config?
>> > >
>> > > I configured the kernel using exynos_defconfig and that gives me:
>> > >
>> > > # CONFIG_PMIC_ADP5520 is not set
>> > > # CONFIG_PMIC_DA903X is not set
>> > >
>> > > Should I be using other defconfig for this board?  exynos_defconfig
>> > > used to work in 3.14.  Cheers,
>> >
>> > Well, unfortunately exynos_defconfig is known to be far from being
>> > reasonable. Right now it should be considered just as a base to
>> > configure the kernel for Exynos SoCs. Most of board specific options
>> > (and many of SoC-wide ones) need to be selected manually.
>> >
>> > Anyway, with the number of Exynos boards supported in mainline, I don't
>> > think we will be ever going to enable all options for all the supported
>> > boards by default in defconfig, especially considering the fact that we
>> > will be moving to generic multi_v7_defconfig and likely dropping
>> > exynos_defconfig completely.
>
> Well, keeping exynos_defconfig would be helpful even if exynos multiplatform is available. Please see the case of omap2plus_defconfig?
>
>> >
>> > As for now, I believe you should just make sure yourself that any
>> > options relevant to your board are enabled.
>>
>> Great.  And I assume that there isn't a list of those options in the
>> web.  So how do I know what options are relevant to my board?  By
>> sending emails to linux-samsung-soc whenever it fails to boot?
>>
> I think, we need to enable all of regarding configs for each exynos boards so that exynos_defconfig can cover whenever.

You need the following patch to mount the MMC. Without this the regulator will
not be enabled which is required by MMC.

ARM: exynos_defconfig: Enable HS-I2C
http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/27527

Kukjin, can you please apply this patch?

-- 
With warm regards,
Sachin

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Javi Merino]

Hi Sachin,

On Mon, Apr 28, 2014 at 05:30:19AM +0100, Sachin Kamat wrote:
> On 26 April 2014 16:49, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Javi Merino wrote:
> >>
> >> On Fri, Apr 25, 2014 at 09:35:35PM +0100, Tomasz Figa wrote:
> >> > On 25.04.2014 22:30, Javi Merino wrote:
> >> > > On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote:
> >> > >> On 25.04.2014 22:11, Javi Merino wrote:
> >> > >>> d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board)
> >> > >>> added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the
> >> > >>> DT.  However, this makes the kernel fail to boot on the arndale-octa
> >> > >>> spews:
> >> > >>>
> >> > >>> [    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not
> >> found, assuming 1 slot is available
> >> > >>> [    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests
> >> probe deferral
> >> > >>> [    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not
> >> found, assuming 1 slot is available
> >> > >>> [    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests
> >> probe deferral
> >> > >>>
> >> > >>> And eventually hangs.  Without the vmmc-supply property in the
> >> > >>> mmc at 12220000 node, the kernel boots again.
> >> > >>>
> >> > >>> Signed-off-by: Javi Merino <javi.merino@arm.com>
> >> > >>> ---
> >> > >>>
> >> > >>> Hi,
> >> > >>>
> >> > >>> Note that I don't know *why* removing the property works, all I know
> >> > >>> is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply
> >> this
> >> > >>> patch.
> >> > >>
> >> > >> Are you sure you have the required PMIC driver enabled in your kernel
> >> > >> config?
> >> > >
> >> > > I configured the kernel using exynos_defconfig and that gives me:
> >> > >
> >> > > # CONFIG_PMIC_ADP5520 is not set
> >> > > # CONFIG_PMIC_DA903X is not set
> >> > >
> >> > > Should I be using other defconfig for this board?  exynos_defconfig
> >> > > used to work in 3.14.  Cheers,
> >> >
> >> > Well, unfortunately exynos_defconfig is known to be far from being
> >> > reasonable. Right now it should be considered just as a base to
> >> > configure the kernel for Exynos SoCs. Most of board specific options
> >> > (and many of SoC-wide ones) need to be selected manually.
> >> >
> >> > Anyway, with the number of Exynos boards supported in mainline, I don't
> >> > think we will be ever going to enable all options for all the supported
> >> > boards by default in defconfig, especially considering the fact that we
> >> > will be moving to generic multi_v7_defconfig and likely dropping
> >> > exynos_defconfig completely.
> >
> > Well, keeping exynos_defconfig would be helpful even if exynos multiplatform is available. Please see the case of omap2plus_defconfig?
> >
> >> >
> >> > As for now, I believe you should just make sure yourself that any
> >> > options relevant to your board are enabled.
> >>
> >> Great.  And I assume that there isn't a list of those options in the
> >> web.  So how do I know what options are relevant to my board?  By
> >> sending emails to linux-samsung-soc whenever it fails to boot?
> >>
> > I think, we need to enable all of regarding configs for each exynos boards so that exynos_defconfig can cover whenever.
> 
> You need the following patch to mount the MMC. Without this the regulator will
> not be enabled which is required by MMC.
> 
> ARM: exynos_defconfig: Enable HS-I2C
> http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/27527

Yes, that's the bit that I was missing.  With that patch 3.15-rc2
boots on my Arndale Octa.

> Kukjin, can you please apply this patch?

You can add my Tested-by for Arndale Octa.

Thanks!
Javi

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

[Kukjin Kim]

Javi Merino wrote:
> 
> Hi Sachin,

Hi Sachin and Javi,

[...]

> >
> > You need the following patch to mount the MMC. Without this the
> regulator will
> > not be enabled which is required by MMC.
> >
> > ARM: exynos_defconfig: Enable HS-I2C
> > http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/27527
> 
> Yes, that's the bit that I was missing.  With that patch 3.15-rc2
> boots on my Arndale Octa.
> 
> > Kukjin, can you please apply this patch?
> 
> You can add my Tested-by for Arndale Octa.
> 
OK, agreed. I will apply the enable HS-I2C on exynos_defconfig with Javi's test tag.

Thanks,
Kukjin