From: george.cherian@ti.com (George Cherian)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs
Date: Mon, 28 Apr 2014 20:11:33 +0530 [thread overview]
Message-ID: <535E689D.7010204@ti.com> (raw)
In-Reply-To: <1398693512-5355-1-git-send-email-guido@vanguardiasur.com.ar>
On 4/28/2014 7:28 PM, Guido Mart?nez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
The series will give dtb build errors
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
Error: arch/arm/boot/dts/am335x-evmsk.dts:367.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-bone.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
Error: arch/arm/boot/dts/am335x-evm.dts:334.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-evmsk.dtb] Error 1
make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1
Error: arch/arm/boot/dts/am335x-igep0033.dtsi:204.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-base0033.dtb] Error 1
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-boneblack.dtb] Error 1
make: *** [dtbs] Error 2
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..b95bc9a 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -183,28 +183,28 @@
> &usb {
> status = "okay";
>
> - control at 44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy at 47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy at 47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb at 47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb at 47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller at 47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
Instead the patch should be
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..06be20a 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -182,31 +182,30 @@
&usb {
status = "okay";
+};
+&usb_ctrl_mod {
+ status = "okay";
+};
- control at 44e10620 {
- status = "okay";
- };
-
- usb-phy at 47401300 {
- status = "okay";
- };
+&usb0_phy {
+ status = "okay";
+};
- usb-phy at 47401b00 {
- status = "okay";
- };
+&usb1_phy {
+ status = "okay";
+};
- usb at 47401000 {
- status = "okay";
- };
+&usb {
+ status = "okay";
+};
- usb at 47401800 {
- status = "okay";
- dr_mode = "host";
- };
+&usb1 {
+ status = "okay";
+ dr_mode = "host";
+};
- dma-controller at 47402000 {
- status = "okay";
- };
+&cppi41dma {
+ status = "okay";
};
--
-George
next prev parent reply other threads:[~2014-04-28 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 13:58 [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs Guido Martínez
2014-04-28 13:58 ` [PATCH 2/4] ARM: dts: am335x-evm: " Guido Martínez
2014-05-06 16:16 ` Felipe Balbi
2014-04-28 13:58 ` [PATCH 3/4] ARM: dts: am335x-evmsk: " Guido Martínez
2014-05-06 16:16 ` Felipe Balbi
2014-04-28 13:58 ` [PATCH 4/4] ARM: dts: am335x-igep0033: " Guido Martínez
2014-05-06 16:17 ` Felipe Balbi
2014-04-28 14:41 ` George Cherian [this message]
2014-04-28 16:10 ` [PATCH 1/4] ARM: dts: am335x-bone-common: " Guido Martínez
2014-05-06 16:16 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E689D.7010204@ti.com \
--to=george.cherian@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).