From: b.brezillon.dev@gmail.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] mtd: nand: define struct nand_timings
Date: Thu, 01 May 2014 19:36:39 +0200 [thread overview]
Message-ID: <53628627.2020401@gmail.com> (raw)
In-Reply-To: <20140430175157.GB2497@norris-Latitude-E6410>
Hi Brian,
On 30/04/2014 19:51, Brian Norris wrote:
> Hi Boris,
>
> On Wed, Mar 12, 2014 at 07:07:36PM +0100, Boris BREZILLON wrote:
>> +
>> +/**
>> + * struct nand_sdr_timings - SDR NAND chip timings
>> + *
>> + * This struct defines the timing requirements of a SDR NAND chip.
>> + * These informations can be found in every NAND datasheets and the timings
>> + * meaning are described in the ONFI specifications:
>> + * www.onfi.org/~/media/ONFI/specs/onfi_3_1_spec.pdf? (chapter 4.15 Timing
> Can you remove the unicode U+200E character?
Sure
>
>> + * Parameters)
> Please document the units for these fields here. It looks like you're
> using picoseconds.
I'll add field units (which are indeed picoseconds) to this comment.
Best Regards,
Boris
next prev parent reply other threads:[~2014-05-01 17:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 18:07 [PATCH v3 0/9] mtd: nand: add sunxi NAND Flash Controller support Boris BREZILLON
2014-03-12 18:07 ` [PATCH v3 1/9] mtd: nand: define struct nand_timings Boris BREZILLON
2014-04-30 17:51 ` Brian Norris
2014-05-01 17:36 ` Boris BREZILLON [this message]
2014-05-08 14:29 ` Lee Jones
2014-05-09 15:47 ` Boris BREZILLON
2014-05-20 18:13 ` Brian Norris
2014-03-12 18:07 ` [PATCH v3 2/9] mtd: nand: add ONFI timing mode to nand_timings converter Boris BREZILLON
2014-04-30 18:06 ` Brian Norris
2014-07-09 17:25 ` Brian Norris
2014-03-12 18:07 ` [PATCH v3 3/9] of: mtd: add NAND timing mode retrieval support Boris BREZILLON
2014-04-30 18:14 ` Brian Norris
2014-03-12 18:07 ` [PATCH v3 4/9] of: mtd: add documentation for the ONFI NAND timing mode property Boris BREZILLON
2014-03-12 18:27 ` Warner Losh
2014-03-12 18:48 ` Boris BREZILLON
2014-05-20 18:25 ` Brian Norris
2014-05-20 19:30 ` Boris BREZILLON
2014-05-20 19:51 ` Jason Gunthorpe
2014-05-20 19:55 ` Brian Norris
2014-05-20 19:52 ` Brian Norris
2014-05-20 21:32 ` Boris BREZILLON
2014-07-09 17:46 ` Brian Norris
2014-03-12 18:07 ` [PATCH v3 5/9] mtd: nand: add sunxi NAND flash controller support Boris BREZILLON
2014-05-09 16:03 ` Ezequiel Garcia
2014-05-09 16:47 ` Boris BREZILLON
2014-05-09 17:05 ` Ezequiel Garcia
2014-05-20 18:49 ` Brian Norris
2014-05-20 19:21 ` Brian Norris
2014-05-20 19:36 ` Boris BREZILLON
2014-03-12 18:07 ` [PATCH v3 6/9] mtd: nand: add sunxi NFC dt bindings doc Boris BREZILLON
2014-03-12 18:07 ` [PATCH v3 7/9] ARM: dt/sunxi: add NFC node to Allwinner A20 SoC Boris BREZILLON
2014-03-12 18:07 ` [PATCH v3 8/9] ARM: dt/sunxi: add A20 NAND controller pin definitions Boris BREZILLON
2014-03-12 18:07 ` [PATCH v3 9/9] ARM: sunxi/dt: enable NAND on cubietruck board Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53628627.2020401@gmail.com \
--to=b.brezillon.dev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).