From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] ARM: Kirkwood: Add DT descriptions for net2big and net5big.
Date: Mon, 05 May 2014 01:12:04 +0200 [thread overview]
Message-ID: <5366C944.1070709@gmail.com> (raw)
In-Reply-To: <20140504225643.GC25314@lunn.ch>
On 05/05/2014 12:56 AM, Andrew Lunn wrote:
>>> + gpio_keys {
>>
>> nit: s/gpio_keys/gpio-keys/
>>
>
> I think this one is debatable. The documentation is called
> gpio_keys.txt, and the example uses gpio_keys. I don't mind chaging it
> in this file, but maybe you can submit a patch changing the example in
> the documentation?
Yes, it definitely is. Both label and node name are allowed to
contain _ and -. Maybe, we should see it is more like a common practice.
Anyway, all comments are nits for a reason :)
I can prepare a patch someday, if I don't forget about it.
Sebastian
>>> + gpio_poweroff {
>>
>> nit: s/gpio_poweroff/gpio-poweroff/
>
> ACK.
>
>> If there is nothing more severe with this, I am sure Jason can
>> just squash in the nits.
>
> This still needs to be tested on hardware, so there is a good chance
> of a respin.
next prev parent reply other threads:[~2014-05-04 23:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 18:35 [PATCH v2 0/5] DT support for LaCie 2Big and 5Big Network v2 Andrew Lunn
2014-05-03 18:35 ` [PATCH v2 1/5] ARM: Kirkwood: Add board file for netxbig LEDs Andrew Lunn
2014-05-03 18:35 ` [PATCH v2 2/5] ARM: Kirkwood: Add DT descriptions for net2big and net5big Andrew Lunn
2014-05-04 21:21 ` Sebastian Hesselbarth
2014-05-04 22:56 ` Andrew Lunn
2014-05-04 23:12 ` Sebastian Hesselbarth [this message]
2014-05-03 18:35 ` [PATCH v2 3/5] ARM: Kirkwood: Document net[25x]big compatible strings Andrew Lunn
2014-05-03 18:35 ` [PATCH v2 4/5] ARM: mvebu: Add LaCie 2Big and 5Big Network v2 Andrew Lunn
2014-05-03 18:35 ` [PATCH v2 5/5] ARM: multi_v5: Enable " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5366C944.1070709@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).