public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: Grafting old platform drivers onto a new DT kernel
Date: Tue, 10 Nov 2015 13:56:51 +0100	[thread overview]
Message-ID: <5369244.M0xZ8N1mEo@wuerfel> (raw)
In-Reply-To: <5641E6C0.8090507@free.fr>

On Tuesday 10 November 2015 13:44:48 Mason wrote:
> On 09/11/2015 18:13, M?ns Rullg?rd wrote:
> 
> > Add something like this:
> > 
> > static const struct of_device_id tangox_sdio_dt_ids[] = {
> >       { .compatible = "sigma,tangox-sdio" },
> >       { }
> > };
> > 
> > static struct platform_driver tangox_platform_sdio0 = {
> >       .probe          = sdhci_tangox_probe,
> 
> It looks like one side effect of this transformation is that
> the probe function cannot be __init anymore? Is that correct?
> 
> For this one particular driver, it weighs 944 bytes. (I guess
> a few kilobytes wasted is no big deal...)

Strictly speaking, it was already broken before. You can
detach and reattach a device from a driver through sysfs,
and that will call the probe function again, so it cannot
be marked as __init.

	Arnd

  reply	other threads:[~2015-11-10 12:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 11:02 Grafting old platform drivers onto a new DT kernel Mason
2015-11-05 15:15 ` Andrew Lunn
2015-11-05 15:42   ` Javier Martinez Canillas
2015-11-09 15:15     ` Mason
2015-11-09 15:36       ` Marc Zyngier
2015-11-09 15:40       ` Måns Rullgård
2015-11-09 16:07         ` Mason
2015-11-09 16:12           ` Måns Rullgård
2015-11-09 17:03             ` Mason
2015-11-09 17:13               ` Måns Rullgård
2015-11-10 12:44                 ` Mason
2015-11-10 12:56                   ` Arnd Bergmann [this message]
2015-11-09 16:26       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5369244.M0xZ8N1mEo@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox