From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomi.valkeinen@ti.com (Tomi Valkeinen) Date: Wed, 7 May 2014 11:12:23 +0300 Subject: [PATCH 3/4] OMAPDSS: panel-sharp-ls037v7dw01: add device tree support In-Reply-To: <1398815562-24113-4-git-send-email-tony@atomide.com> References: <1398815562-24113-1-git-send-email-tony@atomide.com> <1398815562-24113-4-git-send-email-tony@atomide.com> Message-ID: <5369EAE7.3030705@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30/04/14 02:52, Tony Lindgren wrote: > We can pass the GPIO configuration for ls037v7dw01 in a standard > gpios property. > > Signed-off-by: Tony Lindgren > --- > .../bindings/panel/sharp,ls037v7dw01.txt | 53 ++++++++++++++ > .../omap2/displays-new/panel-sharp-ls037v7dw01.c | 84 ++++++++++++++++++++-- > 2 files changed, 133 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt > > diff --git a/Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt b/Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt > new file mode 100644 > index 0000000..7f6f5e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/sharp,ls037v7dw01.txt > @@ -0,0 +1,53 @@ > +SHARP LS037V7DW01 TFT-LCD panel > + > +Required properties: > +- compatible: should be "sharp,ls037v7dw01" > + > +Optional properties: > +- reset-gpios: a GPIO spec for the optional reset pin > +- enable-gpios: a GPIO array for the optional configuration GPIOs > + ordered MO, LR, UD, INI as specified in the LS037V7DW01.pdf file. > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > + > +This panel can have zero to five GPIOs to configure > +to change configuration between QVGA and VGA mode > +and the scan direction. As these pins can be also > +configured with external pulls, all the GPIOs are > +considered optional with holes in the array. > + > +Example when connected to a omap2+ based device: > + > + lcd0: display { > + compatible = "sharp,ls037v7dw01"; > + power-supply = <&lcd_3v3>; > + reset-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; /* gpio155, lcd RESB */ > + enable-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH /* gpio154, lcd MO */ > + &gpio1 2 GPIO_ACTIVE_HIGH /* gpio2, lcd LR */ > + &gpio1 3 GPIO_ACTIVE_HIGH /* gpio3, lcd UD */ > + &gpio5 24 GPIO_ACTIVE_HIGH>; /* gpio152, lcd INI */ Why are most of the gpios in 'enable-gpios'? MO, LR and UD don't really have anything to do with enabling the panel. Why not just have one 'gpios' array with all the gpios, as they are quite a mixed bunch? Tomi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: