From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow
Date: Thu, 08 May 2014 18:12:53 +0200 [thread overview]
Message-ID: <536BAD05.9070401@samsung.com> (raw)
In-Reply-To: <536BA9E8.2030306@suse.de>
On 08.05.2014 17:59, Andreas F?rber wrote:
> Hello,
>
> Am 05.05.2014 14:30, schrieb Vivek Gautam:
>> The exynos5250-snow has a SMSC USB3503 connected in
>> hardware only mode like a PHY. Enable support for it,
>> and add necessary 'reset-gpio' for it.
>>
>> This is in correspondance to similar patch by Mark Brown
>> 7c1b0ec ARM: dts: Enable USB hub on Arndale
>>
>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>> ---
>>
>> Based on 'for-next' branch of kgene's linux-samsung tree.
>>
>> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
>> arch/arm/boot/dts/exynos5250-snow.dts | 14 ++++++++++++++
>> 2 files changed, 21 insertions(+)
>
> The same snippet as for snow also fixed my USB issues on spring.
> Should it go into exynos5250-cros-common.dtsi instead?
The GPIO pins used are different, so I don't think the hub node added by
these patches could be shared.
Also, I believe all you need to add is a simple node as follows
usb_hub {
compatible = "smsc,usb3503a";
reset-gpios = <&gpe1 0 1>;
};
at root level (see my comments to this patch in another reply), which is
affordable to be duplicated for every platform that requires it,
especially if the reset-gpios property differs between boards.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-08 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 12:30 [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow Vivek Gautam
2014-05-05 12:30 ` [PATCH 2/2] ARM: dts: Enable USB 3503 hub on exynos5420-peach-pit Vivek Gautam
2014-05-08 15:59 ` [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow Andreas Färber
2014-05-08 16:12 ` Tomasz Figa [this message]
2014-05-28 22:37 ` Julius Werner
2014-06-02 12:09 ` Vivek Gautam
2014-06-02 17:15 ` Julius Werner
2014-05-08 16:07 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536BAD05.9070401@samsung.com \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).