From: ipaton0@gmail.com (Iain Paton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: imx6: add new board RIoTboard
Date: Fri, 09 May 2014 08:48:07 +0100 [thread overview]
Message-ID: <536C8837.9090802@gmail.com> (raw)
In-Reply-To: <20140509030938.GK2794@dragon>
On 09/05/14 04:09, Shawn Guo wrote:
> On Thu, May 08, 2014 at 10:13:49AM +0100, Iain Paton wrote:
>> +&ecspi1 {
>> + fsl,spi-num-chipselects = <1>;
>> + cs-gpios = <&gpio5 17 0>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_ecspi1>;
>> + status = "okay";
>> +
>> + spidev at 0 {
>> + spi-max-frequency = <24000000>;
>> + reg = <0>;
>> + compatible = "spidev";
>> + };
>
> What's this? Is this the common way we code spi devices in device tree?
I'd appreciate your guidance here, what would you prefer?
My reasons for adding spidev were as follows:
1. The SPI pins are not used on the board, they go to an expansion header.
2. Board is targeted at makers who are likely to want to attach
external devices.
3. Experience has been that if they don't find an easy and already
configured way to use something they reach for devmem2 or similar.
4. devicetree is often seen as being too hard by people who come to these
boards from things like arduino
I've already had questions on how to find the physical address of /dev/i2c-0
seemingly due to some of the above.
I'm happy to drop the spidev entries if that's what you'd prefer, but if I
do that I'm undecided if I should then just drop the ecspi sections as well
and free up more gpio pins on the expansion header for other uses.
I'll tidy up all the other comments, and use your suggested method for the
i2c4 changes.
Thanks,
Iain
next prev parent reply other threads:[~2014-05-09 7:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 22:03 [RFC PATCH] ARM: dts: imx6: add new board RIoTboard Iain Paton
2014-05-08 2:27 ` Fabio Estevam
2014-05-08 9:10 ` Iain Paton
2014-05-08 5:41 ` Shawn Guo
2014-05-08 9:09 ` Iain Paton
2014-05-08 9:13 ` [PATCH v2] " Iain Paton
2014-05-08 13:45 ` Fabio Estevam
2014-05-08 13:54 ` Alexander Shiyan
2014-05-08 14:36 ` Iain Paton
2014-05-08 14:50 ` Alexander Shiyan
2014-05-08 17:12 ` Iain Paton
2014-05-08 17:32 ` Alexander Shiyan
2014-05-08 19:27 ` Iain Paton
2014-05-08 19:37 ` Alexander Shiyan
2014-05-09 2:19 ` Shawn Guo
2014-05-09 3:09 ` Shawn Guo
2014-05-09 7:48 ` Iain Paton [this message]
2014-05-09 12:08 ` Shawn Guo
2014-05-09 14:16 ` Iain Paton
2014-05-09 14:21 ` Shawn Guo
2014-05-09 15:01 ` [PATCH v3 1/2] ARM: dts: imx6: i2c4 cleanup Iain Paton
2014-05-09 15:30 ` Fabio Estevam
2014-05-10 6:28 ` Shawn Guo
2014-05-09 15:02 ` [PATCH v3 2/2] ARM: dts: imx6: add new board RIoTboard Iain Paton
2014-05-09 15:31 ` Fabio Estevam
2014-05-10 6:28 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C8837.9090802@gmail.com \
--to=ipaton0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).