From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Fri, 9 May 2014 14:57:45 +0200 Subject: [PATCH v2 2/2] iio:adc: at91 requires the input subsystem In-Reply-To: <4163305.otOGv8yVK1@wuerfel> References: <1399560433-1402630-1-git-send-email-arnd@arndb.de> <1399560990-1402858-13-git-send-email-arnd@arndb.de> <536CA78C.5070603@atmel.com> <4163305.otOGv8yVK1@wuerfel> Message-ID: <536CD0C9.4040603@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/05/2014 13:43, Arnd Bergmann : > On Friday 09 May 2014 12:01:48 Nicolas Ferre wrote: >> On 08/05/2014 16:56, Arnd Bergmann : >>> Building the at91 adc driver with CONFIG_INPUT disabled results in this >>> build error: >>> >>> ERROR: "input_event" [drivers/iio/adc/at91_adc.ko] undefined! >>> ERROR: "input_unregister_device" [drivers/iio/adc/at91_adc.ko] undefined! >>> ERROR: "input_free_device" [drivers/iio/adc/at91_adc.ko] undefined! >>> ERROR: "input_register_device" [drivers/iio/adc/at91_adc.ko] undefined! >>> ERROR: "input_set_abs_params" [drivers/iio/adc/at91_adc.ko] undefined! >>> ERROR: "input_allocate_device" [drivers/iio/adc/at91_adc.ko] undefined! >>> >>> To make sure we can build random configurations, this turns on CONFIG_INPUT >>> whenever CONFIG_AT91_ADC is enabled. >> >> Isn't it a "select" instead of "depends" that is required then? > > It seems I fixed the patch at some point but didn't update the message. > > In general, we should not mix 'depends on' and 'select' for the same symbol, > since that causes extra confusion. > > In case of CONFIG_INPUT, almost all the users do 'depends on INPUT', with > a few exceptions that seem to be done in error. Ok, that makes sense. > Updated patch below. Thanks Arnd. > Arnd > > 8<---- > >>>From 4679d63b24a681d9c6afcfdde266bae0f940e90b Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann > Date: Wed, 9 Apr 2014 17:18:10 +0200 > Subject: [PATCH] [SUBMITTED] iio:adc: at91 requires the input subsystem > > Building the at91 adc driver with CONFIG_INPUT disabled results in this > build error: > > ERROR: "input_event" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_unregister_device" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_free_device" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_register_device" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_set_abs_params" [drivers/iio/adc/at91_adc.ko] undefined! > ERROR: "input_allocate_device" [drivers/iio/adc/at91_adc.ko] undefined! > > To make sure we can build random configurations, this adds a Kconfig > dependency on CONFIG_INPUT, as we do for other similar drivers. > > Signed-off-by: Arnd Bergmann > Cc: linux-iio at vger.kernel.org > Cc: Josh Wu > Cc: Jonathan Cameron > Cc: Maxime Ripard Acked-by: Nicolas Ferre Bye, > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 90f596d..a80d236 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -110,6 +110,7 @@ config AD799X > config AT91_ADC > tristate "Atmel AT91 ADC" > depends on ARCH_AT91 > + depends on INPUT > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > select SYSFS > > > -- Nicolas Ferre