* [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node @ 2014-04-21 4:29 Wenyou Yang 2014-04-21 9:54 ` Alexandre Belloni 2014-05-12 9:56 ` Nicolas Ferre 0 siblings, 2 replies; 7+ messages in thread From: Wenyou Yang @ 2014-04-21 4:29 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 42 +++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts index ce13755..57cdd83 100644 --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts @@ -48,6 +48,48 @@ i2c1: i2c at f0018000 { status = "okay"; + + pmic: act8865 at 5b { + compatible = "active-semi,act8865"; + reg = <0x5b>; + status = "okay"; + + regulators { + vcc_1v8_reg: DCDC_REG1 { + regulator-name = "VCC_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + vcc_1v2_reg: DCDC_REG2 { + regulator-name = "VCC_1V2"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + }; + + vcc_3v3_reg: DCDC_REG3 { + regulator-name = "VCC_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vddfuse_reg: LDO_REG1 { + regulator-name = "FUSE_2V5"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + }; + + vddana_reg: LDO_REG2 { + regulator-name = "VDDANA"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + }; + }; }; macb0: ethernet at f0028000 { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node 2014-04-21 4:29 [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node Wenyou Yang @ 2014-04-21 9:54 ` Alexandre Belloni 2014-04-21 12:22 ` Alexandre Belloni 2014-05-12 9:56 ` Nicolas Ferre 1 sibling, 1 reply; 7+ messages in thread From: Alexandre Belloni @ 2014-04-21 9:54 UTC (permalink / raw) To: linux-arm-kernel Hi, On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 42 +++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index ce13755..57cdd83 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -48,6 +48,48 @@ > > i2c1: i2c at f0018000 { > status = "okay"; > + > + pmic: act8865 at 5b { > + compatible = "active-semi,act8865"; > + reg = <0x5b>; > + status = "okay"; > + > + regulators { > + vcc_1v8_reg: DCDC_REG1 { > + regulator-name = "VCC_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + vcc_1v2_reg: DCDC_REG2 { > + regulator-name = "VCC_1V2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + }; > + > + vcc_3v3_reg: DCDC_REG3 { > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vddfuse_reg: LDO_REG1 { > + regulator-name = "FUSE_2V5"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + }; > + > + vddana_reg: LDO_REG2 { > + regulator-name = "VDDANA"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; I'm pretty sure that one is not always on as you actually have to configure it to get any voltage. Are you sure you want to set the regulator-always-on property here ? > + }; > + }; > + }; > }; > > macb0: ethernet at f0028000 { > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node 2014-04-21 9:54 ` Alexandre Belloni @ 2014-04-21 12:22 ` Alexandre Belloni 2014-04-22 1:37 ` Yang, Wenyou 0 siblings, 1 reply; 7+ messages in thread From: Alexandre Belloni @ 2014-04-21 12:22 UTC (permalink / raw) To: linux-arm-kernel On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : > Hi, > > On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > > + > > + vddana_reg: LDO_REG2 { > > + regulator-name = "VDDANA"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > I'm pretty sure that one is not always on as you actually have to > configure it to get any voltage. Are you sure you want to set the > regulator-always-on property here ? > Just to clarify my though, wouldn't it be better to make the ADC driver handle that regulator instead of using regulator-always-on ? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node 2014-04-21 12:22 ` Alexandre Belloni @ 2014-04-22 1:37 ` Yang, Wenyou 2014-05-09 15:30 ` Nicolas Ferre 0 siblings, 1 reply; 7+ messages in thread From: Yang, Wenyou @ 2014-04-22 1:37 UTC (permalink / raw) To: linux-arm-kernel Hi, > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com] > Sent: Monday, April 21, 2014 8:22 PM > To: Yang, Wenyou > Cc: devicetree at vger.kernel.org; Ferre, Nicolas; linux- > kernel at vger.kernel.org; robh+dt at kernel.org; broonie at kernel.org; linux- > arm-kernel at lists.infradead.org > Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator > device node > > On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : > > Hi, > > > > On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > > > + > > > + vddana_reg: LDO_REG2 { > > > + regulator-name = "VDDANA"; > > > + regulator-min-microvolt = > <3300000>; > > > + regulator-max-microvolt = > <3300000>; > > > + regulator-always-on; > > > > I'm pretty sure that one is not always on as you actually have to > > configure it to get any voltage. Are you sure you want to set the > > regulator-always-on property here ? > > > > Just to clarify my though, wouldn't it be better to make the ADC driver > handle that regulator instead of using regulator-always-on ? Yes, you are right. It should not use regulator-always-on property for this regulator. It is ADC driver and ISI driver to handle it(The ISI takes PCK for clock). I will send new version patch. Thanks > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free- > electrons.com Best Regards, Wenyou Yang ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node 2014-04-22 1:37 ` Yang, Wenyou @ 2014-05-09 15:30 ` Nicolas Ferre 2014-05-12 4:42 ` Yang, Wenyou 0 siblings, 1 reply; 7+ messages in thread From: Nicolas Ferre @ 2014-05-09 15:30 UTC (permalink / raw) To: linux-arm-kernel On 22/04/2014 03:37, Yang, Wenyou : > Hi, > >> -----Original Message----- >> From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com] >> Sent: Monday, April 21, 2014 8:22 PM >> To: Yang, Wenyou >> Cc: devicetree at vger.kernel.org; Ferre, Nicolas; linux- >> kernel at vger.kernel.org; robh+dt at kernel.org; broonie at kernel.org; linux- >> arm-kernel at lists.infradead.org >> Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator >> device node >> >> On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : >>> Hi, >>> >>> On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : >>>> + >>>> + vddana_reg: LDO_REG2 { >>>> + regulator-name = "VDDANA"; >>>> + regulator-min-microvolt = >> <3300000>; >>>> + regulator-max-microvolt = >> <3300000>; >>>> + regulator-always-on; >>> >>> I'm pretty sure that one is not always on as you actually have to >>> configure it to get any voltage. Are you sure you want to set the >>> regulator-always-on property here ? >>> >> >> Just to clarify my though, wouldn't it be better to make the ADC driver >> handle that regulator instead of using regulator-always-on ? > Yes, you are right. > It should not use regulator-always-on property for this regulator. > It is ADC driver and ISI driver to handle it(The ISI takes PCK for clock). Hi Wenyou and Alexandre, After talking to our system engineers, it not usual to avoid to power the VDDANA rail. In fact it will prevent you to use all the pads that are powered by VDDANA: PD20-PD31. Moreover, even if you do not activate the ADC output on these lines you won't be able to use them as plain GPIO... (Cf. package and pinout section of the datasheet). As the ADVREF pin of the SoC is connected to the VDDANA on this board (even if this default configuration can be modified with a soldering iron), we have to note that we may consume a little bit more power. But still, I would recommend to keep the "regulator-always-on" property on this node. Do you agree and allow me to take your first revision of the patch? Bye, -- Nicolas Ferre ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node 2014-05-09 15:30 ` Nicolas Ferre @ 2014-05-12 4:42 ` Yang, Wenyou 0 siblings, 0 replies; 7+ messages in thread From: Yang, Wenyou @ 2014-05-12 4:42 UTC (permalink / raw) To: linux-arm-kernel > -----Original Message----- > From: Ferre, Nicolas > Sent: Friday, May 09, 2014 11:31 PM > To: Yang, Wenyou; Alexandre Belloni > Cc: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; > robh+dt at kernel.org; broonie at kernel.org; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator > device node > > On 22/04/2014 03:37, Yang, Wenyou : > > Hi, > > > >> -----Original Message----- > >> From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com] > >> Sent: Monday, April 21, 2014 8:22 PM > >> To: Yang, Wenyou > >> Cc: devicetree at vger.kernel.org; Ferre, Nicolas; linux- > >> kernel at vger.kernel.org; robh+dt at kernel.org; broonie at kernel.org; > >> linux- arm-kernel at lists.infradead.org > >> Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the > >> regulator device node > >> > >> On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : > >>> Hi, > >>> > >>> On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > >>>> + > >>>> + vddana_reg: LDO_REG2 { > >>>> + regulator-name = > "VDDANA"; > >>>> + regulator-min-microvolt > = > >> <3300000>; > >>>> + regulator-max-microvolt > = > >> <3300000>; > >>>> + regulator-always-on; > >>> > >>> I'm pretty sure that one is not always on as you actually have to > >>> configure it to get any voltage. Are you sure you want to set the > >>> regulator-always-on property here ? > >>> > >> > >> Just to clarify my though, wouldn't it be better to make the ADC > >> driver handle that regulator instead of using regulator-always-on ? > > Yes, you are right. > > It should not use regulator-always-on property for this regulator. > > It is ADC driver and ISI driver to handle it(The ISI takes PCK for > clock). > > Hi Wenyou and Alexandre, > > After talking to our system engineers, it not usual to avoid to power > the VDDANA rail. In fact it will prevent you to use all the pads that > are powered by VDDANA: PD20-PD31. Moreover, even if you do not activate > the ADC output on these lines you won't be able to use them as plain > GPIO... (Cf. package and pinout section of the datasheet). > > As the ADVREF pin of the SoC is connected to the VDDANA on this board > (even if this default configuration can be modified with a soldering > iron), we have to note that we may consume a little bit more power. > > But still, I would recommend to keep the "regulator-always-on" property > on this node. Do you agree and allow me to take your first revision of > the patch? I agree. > > > Bye, > -- > Nicolas Ferre Best Regards, Wenyou Yang ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node 2014-04-21 4:29 [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node Wenyou Yang 2014-04-21 9:54 ` Alexandre Belloni @ 2014-05-12 9:56 ` Nicolas Ferre 1 sibling, 0 replies; 7+ messages in thread From: Nicolas Ferre @ 2014-05-12 9:56 UTC (permalink / raw) To: linux-arm-kernel On 21/04/2014 06:29, Wenyou Yang : > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Stacked on the at91-3.16-dt2 branch. Thanks, bye, > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 42 +++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index ce13755..57cdd83 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -48,6 +48,48 @@ > > i2c1: i2c at f0018000 { > status = "okay"; > + > + pmic: act8865 at 5b { > + compatible = "active-semi,act8865"; > + reg = <0x5b>; > + status = "okay"; > + > + regulators { > + vcc_1v8_reg: DCDC_REG1 { > + regulator-name = "VCC_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + vcc_1v2_reg: DCDC_REG2 { > + regulator-name = "VCC_1V2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + }; > + > + vcc_3v3_reg: DCDC_REG3 { > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vddfuse_reg: LDO_REG1 { > + regulator-name = "FUSE_2V5"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + }; > + > + vddana_reg: LDO_REG2 { > + regulator-name = "VDDANA"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + }; > + }; > }; > > macb0: ethernet at f0028000 { > -- Nicolas Ferre ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-05-12 9:56 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-21 4:29 [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node Wenyou Yang 2014-04-21 9:54 ` Alexandre Belloni 2014-04-21 12:22 ` Alexandre Belloni 2014-04-22 1:37 ` Yang, Wenyou 2014-05-09 15:30 ` Nicolas Ferre 2014-05-12 4:42 ` Yang, Wenyou 2014-05-12 9:56 ` Nicolas Ferre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).