From: george.cherian@ti.com (George Cherian)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early
Date: Mon, 12 May 2014 10:29:52 +0530 [thread overview]
Message-ID: <53705548.7020400@ti.com> (raw)
In-Reply-To: <1398373881-23369-1-git-send-email-ezequiel@vanguardiasur.com.ar>
On 4/25/2014 2:41 AM, Ezequiel Garcia wrote:
> The DMA controller is needed for the USB controller to be correctly
> registered. Therefore, if the DMA node is located at the end an unecessary
> probe deferral is produced systematically.
>
> This is easily fixed by moving the node at the beggining of the child list,
> so it's probed first.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Acked-by: George Cherian <george.cherian@ti.com>
> --
> v1->v2:
> * Added a comment to prevent a future clean-up based on the memory offset.
>
> arch/arm/boot/dts/am33xx.dtsi | 34 ++++++++++++++++++++--------------
> 1 file changed, 20 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 9770e35..02e1eb6 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -453,6 +453,26 @@
> ti,hwmods = "usb_otg_hs";
> status = "disabled";
>
> + /*
> + * The probe order matches the child ordering so the
> + * dma-controller node must be the first one to prevent
> + * spurious probe deferrals.
> + */
> + cppi41dma: dma-controller at 47402000 {
> + compatible = "ti,am3359-cppi41";
> + reg = <0x47400000 0x1000
> + 0x47402000 0x1000
> + 0x47403000 0x1000
> + 0x47404000 0x4000>;
> + reg-names = "glue", "controller", "scheduler", "queuemgr";
> + interrupts = <17>;
> + interrupt-names = "glue";
> + #dma-cells = <2>;
> + #dma-channels = <30>;
> + #dma-requests = <256>;
> + status = "disabled";
> + };
> +
> usb_ctrl_mod: control at 44e10620 {
> compatible = "ti,am335x-usb-ctrl-module";
> reg = <0x44e10620 0x10
> @@ -556,20 +576,6 @@
> "tx14", "tx15";
> };
>
> - cppi41dma: dma-controller at 47402000 {
> - compatible = "ti,am3359-cppi41";
> - reg = <0x47400000 0x1000
> - 0x47402000 0x1000
> - 0x47403000 0x1000
> - 0x47404000 0x4000>;
> - reg-names = "glue", "controller", "scheduler", "queuemgr";
> - interrupts = <17>;
> - interrupt-names = "glue";
> - #dma-cells = <2>;
> - #dma-channels = <30>;
> - #dma-requests = <256>;
> - status = "disabled";
> - };
> };
>
> epwmss0: epwmss at 48300000 {
--
-George
next prev parent reply other threads:[~2014-05-12 4:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 21:11 [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early Ezequiel Garcia
2014-04-29 6:19 ` Yegor Yefremov
2014-04-29 7:58 ` George Cherian
2014-04-29 8:06 ` Sebastian Andrzej Siewior
2014-04-29 8:27 ` George Cherian
2014-04-29 9:09 ` Sebastian Andrzej Siewior
2014-04-29 13:50 ` Ezequiel García
2014-05-08 17:00 ` Ezequiel García
2014-05-09 6:22 ` George Cherian
2014-05-09 7:25 ` Sebastian Andrzej Siewior
2014-05-09 10:07 ` George Cherian
2014-05-09 13:26 ` Ezequiel García
2014-05-12 4:59 ` George Cherian [this message]
2014-05-12 14:02 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53705548.7020400@ti.com \
--to=george.cherian@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).