From mboxrd@z Thu Jan 1 00:00:00 1970 From: hdegoede@redhat.com (Hans de Goede) Date: Wed, 14 May 2014 14:06:34 +0200 Subject: [PATCH v13 2/2] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs In-Reply-To: References: <1399896288-5826-1-git-send-email-hdegoede@redhat.com> <1399896288-5826-3-git-send-email-hdegoede@redhat.com> <5370C5D1.2070901@broadcom.com> Message-ID: <53735C4A.70502@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 05/14/2014 02:03 PM, Ulf Hansson wrote: > On 12 May 2014 15:00, Arend van Spriel wrote: >> On 05/12/2014 02:04 PM, Hans de Goede wrote: >>> >>> From: David Lanzend?rfer >>> >>> The Allwinner sunxi mmc host uses dma in bus-master mode using a built-in >>> designware idmac controller, which is identical to the one found in the >>> mmc-dw >>> hosts. However the rest of the host is not identical to mmc-dw, it deals >>> with >>> sending stop commands in hardware which makes it significantly different >>> from the mmc-dw devices. >>> >>> HdG: Various cleanups and fixes. >> >> >> Just nitpicking, but usually the above line should be added below the >> original signoff, so: >> >>> Signed-off-by: David Lanzend?rfer >> >> [hdegoede at redhat.com: various cleanups and fixes] >> >>> Signed-off-by: Hans de Goede >> >> >> As is documented in SubmittingPatches. >> >> Gr. AvS > > > This looks good to me, thanks Hans! > > I will include this in the next PR I send to Chris, I will also take > the liberty to fixup the commit msg as pointed out by Arend. Great, thanks! Regards, Hans