From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420
Date: Thu, 15 May 2014 23:26:51 +0200 [thread overview]
Message-ID: <5375311B.2010202@gmail.com> (raw)
In-Reply-To: <1400054637-21505-6-git-send-email-chander.kashyap@linaro.org>
Hi Chander,
On 14.05.2014 10:03, Chander Kashyap wrote:
> Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle driver.
> Hence do not allow exynos cpuidle driver registration for Exynos5420.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> Signed-off-by: Chander Kashyap <k.chander@samsung.com>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm/mach-exynos/cpuidle.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
> index 3dd385e..807a386 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -218,6 +218,9 @@ static int exynos_cpuidle_probe(struct platform_device *pdev)
> int cpu_id, ret;
> struct cpuidle_device *device;
>
> + if (soc_is_exynos5420())
> + return -ENODEV;
> +
> if (soc_is_exynos5250())
> exynos5_core_down_clk();
>
>
Why not put this in exynos.c in exynos_dt_machine_init(), so
exynos_cpuidle_init() is called only if not running on Exynos5420?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-15 21:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ANuQgHGSPJ45tbrVppAVpOqF0OfHacPWfX=S5mOVxTPr66f7vg@mail.gmail.com>
2014-05-14 8:03 ` [PATCH v5 0/6] add cpuidle support for Exynos5420 Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 1/6] driver: cpuidle-big-little: add of_device_id structure Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 2/6] arm: exynos: add generic function to calculate cpu number Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 3/6] cpuidle: config: Add ARCH_EXYNOS entry to select cpuidle-big-little driver Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420 Chander Kashyap
2014-05-14 13:04 ` Arnd Bergmann
2014-05-14 14:06 ` Lorenzo Pieralisi
2014-05-14 8:03 ` [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration " Chander Kashyap
2014-05-15 21:26 ` Tomasz Figa [this message]
2014-05-16 4:01 ` Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 0/6] add cpuidle support " Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 1/6] driver: cpuidle-big-little: add of_device_id structure Chander Kashyap
2014-05-28 8:58 ` Daniel Lezcano
2014-05-16 8:03 ` [PATCH v6 2/6] arm: exynos: add generic function to calculate cpu number Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 3/6] cpuidle: config: Add ARCH_EXYNOS entry to select cpuidle-big-little driver Chander Kashyap
2014-05-28 9:00 ` Daniel Lezcano
2014-05-16 8:03 ` [PATCH v6 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420 Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 5/6] exynos: cpuidle: do not allow cpuidle registration " Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 6/6] mcpm: exynos: populate suspend and powered_up callbacks Chander Kashyap
2014-05-19 5:40 ` [PATCH v6 0/6] add cpuidle support for Exynos5420 Chander Kashyap
2014-05-26 4:40 ` Chander Kashyap
2014-05-26 10:29 ` Tomasz Figa
2014-05-28 4:28 ` Chander Kashyap
2014-05-28 4:35 ` Kukjin Kim
2014-05-28 9:02 ` Daniel Lezcano
2014-05-29 4:37 ` Chander Kashyap
2014-06-10 12:38 ` Chander M. Kashyap
2014-05-14 8:03 ` [PATCH v5 6/6] mcpm: exynos: populate suspend and powered_up callbacks Chander Kashyap
2014-05-14 9:56 ` [PATCH v5 0/6] add cpuidle support for Exynos5420 Daniel Lezcano
2014-05-14 10:43 ` Chander Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5375311B.2010202@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).