From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1356C433EF for ; Fri, 10 Jun 2022 10:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ADPRKDbHoEMpIuqwACstOKTuyl+ijOgplcuGqdtEuyM=; b=4BfZVEJohHkRnT h9DMUBYocc8KpQKmeWhKe1lCj6RCUkFhaLhf2EJ/EeyGgDC6dzG/ZqrSKuXxUh/8755/+/DtpULKt yNLKRbB31Pt4x7NzwJMKCO7kqTQDyY+bsjb7ZezwM1Zj3D/RvqDgqLhU94q/mtq2gtrbtBHj7fKi/ X5X2Vo8lgYOwjroJxAyuQb1NoGZmwuWFbZCAW+orygjqjZ8yWLq3HeaYy19nh7dBpm7lx3xT2zIJa xTbv0X98+1Nx4BTiLwOSgKHD9r0dSeVzl4xhhrrD9xX5mCL9+FVVfo+uTg6cDkJoKX/0ZQtjoB8Ol GHBYrMR+kv8tdB3VXyPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzbbn-007VBo-Du; Fri, 10 Jun 2022 10:11:16 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzbWj-007SWW-Nn for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 10:06:05 +0000 Received: by mail-ed1-x533.google.com with SMTP id w27so34531628edl.7 for ; Fri, 10 Jun 2022 03:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=Q5vsmxWtwaYG8oW1AvQlgwQ8iE5Q0pMcGpxfbWiaZG0=; b=mAwnc2FFbtLQIpZr3EhYJcGHEjUDTrbX5Jx0lJTRxxZ0qBjgwzPJoDo1t/rjo0CWE3 yerDl7ktV0DQWz4+QGdECsB949KbT+RbfG3jjSbSDHNcLk/Qq32eONfK5Y+syiadgwxc ksxL5klIEiyxCxjJvC8ufzFhxN2Xdp4ryDJ2tg7eEFag1jBlUpf70OVlutNMCQvvFixk 895brrs4P/H1ae1l2GIH/45CaIzX/PQ3r60ns2tsqGQzOzuj0bVlcbrTvxO6/D2WULPH VqEwY5ydtSucv3FLVw+nIzGu2j0Jn0IuF9KeJQMxm25MK3JNOoeX21Lku7r4L+7+wnEq em5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Q5vsmxWtwaYG8oW1AvQlgwQ8iE5Q0pMcGpxfbWiaZG0=; b=IlQd9llxkUwd0A5aXO1fyetntCrlDqhi9bmKOebnE56o7zrEYxtPQGTRrjJCjNRE+s gup6kiLMvHMeJHLxKYlGXJiV8LcyQlVyvWJaS1zx1Ba81ubcNCuandJ4xD7HS7ywf2az VGUk48oVaUkam7nlR0TGZJ8YTWhfsymiOTcS/V3WqV0y0wvVM+QAPk9qsHiwvQppL6hr CEqUbmrRPJeFTltmqiBhguP6CDsWQe/zlvSEZHBYZ+W74XYbL2odtzutDiZCd8ctA8Ug Aw7sLcS3bUkS6m3TRhC42++OSW0sJLn3uSrJXUNhmRU+0Td0S6RwUZCzuZXm3r0cXrBv +HQQ== X-Gm-Message-State: AOAM533+kMs62ODNoWApjY4ifizgkqSIrJOaQXWRz5T0/n8UWanExZHG 30d2aJop/0sVI0KPZOMDihHlzw== X-Google-Smtp-Source: ABdhPJw+10Yv7YpKYQWS1YFaBYbE6qXvaEMzJNgXTJK+zRmZH81nGhz+1LAX3otPNb4lPpztjPphrw== X-Received: by 2002:a05:6402:50:b0:431:69fc:eff4 with SMTP id f16-20020a056402005000b0043169fceff4mr26419944edu.243.1654855553741; Fri, 10 Jun 2022 03:05:53 -0700 (PDT) Received: from [192.168.0.202] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i7-20020a170906444700b0070e238ff66fsm9834067ejp.96.2022.06.10.03.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 03:05:53 -0700 (PDT) Message-ID: <537986d4-376e-d787-1581-cf0b0d525daa@linaro.org> Date: Fri, 10 Jun 2022 12:05:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 44/48] ARM: dts: at91: align gpio-key node names with dtschema Content-Language: en-US To: Claudiu.Beznea@microchip.com, arnd@arndb.de, olof@lixom.net, arm@kernel.org, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, peda@axentia.se, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> <20220609114047.380793-5-krzysztof.kozlowski@linaro.org> <42e8f573-cfc2-dfa4-1740-b0a29521628e@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <42e8f573-cfc2-dfa4-1740-b0a29521628e@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_030601_816954_806DD577 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/06/2022 09:12, Claudiu.Beznea@microchip.com wrote: >> compatible = "gpio-keys"; >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> status = "okay"; >> >> - sw1 { >> + switch-1 { > > This is acutally a button labeled on board as SW1. It has been wrongly > carried over from older DTSes. Maybe it would worth to have it now here as > button instead of switch. Sure, I'll name it "button-1". Could be also "button-sw1" if ou prefer. > >> label = "SW1"; >> gpios = <&pioD 18 GPIO_ACTIVE_LOW>; >> linux,code=; >> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >> index 08f0d4b995ff..96c9290007a8 100644 >> --- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >> +++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts >> @@ -478,13 +478,13 @@ can1: can@fc050000 { >> }; >> }; >> >> - gpio_keys { >> + gpio-keys { >> compatible = "gpio-keys"; >> >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> >> - pb4 { >> + button { >> label = "USER"; >> gpios = <&pioA PIN_PA29 GPIO_ACTIVE_LOW>; >> linux,code = ; >> diff --git a/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >> index 5e8755f22784..d5652c974748 100644 >> --- a/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >> +++ b/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts >> @@ -26,14 +26,14 @@ chosen { >> stdout-path = "serial0:115200n8"; >> }; >> >> - gpio_keys { >> + gpio-keys { >> compatible = "gpio-keys"; >> >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> status = "okay"; >> >> - sw4 { >> + switch-4 { > > Same here, this is a button not a switch. Sure, then button-1 or button-sw4 > >> label = "USER BUTTON"; >> gpios = <&pioA PIN_PB2 GPIO_ACTIVE_LOW>; >> linux,code = ; >> diff --git a/arch/arm/boot/dts/at91-sama5d2_icp.dts b/arch/arm/boot/dts/at91-sama5d2_icp.dts >> index 806eb1d911d7..d7b59e16a081 100644 >> --- a/arch/arm/boot/dts/at91-sama5d2_icp.dts >> +++ b/arch/arm/boot/dts/at91-sama5d2_icp.dts >> @@ -42,14 +42,14 @@ main_xtal { >> }; >> }; >> >> - gpio_keys { >> + gpio-keys { >> compatible = "gpio-keys"; >> >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_key_gpio_default>; >> status = "okay"; >> >> - sw4 { >> + switch-4 { > > Same here, button not switch. > > Other than this, looks good to me. Thanks for checking Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel