From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.coquelin@st.com (Maxime Coquelin) Date: Tue, 20 May 2014 10:41:07 +0200 Subject: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x In-Reply-To: <20140520082858.GF20874@lee--X1> References: <1398756095-32542-1-git-send-email-lee.jones@linaro.org> <1398756095-32542-4-git-send-email-lee.jones@linaro.org> <537A265E.8080407@st.com> <20140519155106.GR4978@lee--X1> <537B01E9.8020507@st.com> <20140520082858.GF20874@lee--X1> Message-ID: <537B1523.1010503@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/20/2014 10:28 AM, Lee Jones wrote: >>>>> The MiPHY365x is a Generic PHY which can serve various SATA or PCIe >>>>> devices. It has 2 ports which it can use for either; both SATA, both >>>>> PCIe or one of each in any configuration. >>>>> >>>>> Cc: Srinivas Kandagatla >>>>> Acked-by: Mark Rutland >>>>> Acked-by: Alexandre Torgue >>>>> Signed-off-by: Lee Jones >>>>> --- >>>>> arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++++++++++++++++++++++ >>>>> arch/arm/boot/dts/stih416-b2020.dts | 6 ++++++ >>>>> arch/arm/boot/dts/stih416.dtsi | 14 ++++++++++++++ >>>>> 3 files changed, 42 insertions(+) >>>>> create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts >>>>> >>>>> diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020-revE.dts >>>>> new file mode 100644 >>>>> index 0000000..23fdaf7 >>>>> --- /dev/null >>>>> +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts >>>>> @@ -0,0 +1,22 @@ >>>>> +/* >>>>> + * Copyright (C) 2014 STMicroelectronics Limited. >>>>> + * Author: Lee Jones >>>>> + * >>>>> + * This program is free software; you can redistribute it and/or modify >>>>> + * it under the terms of the GNU General Public License version 2 as >>>>> + * publishhed by the Free Software Foundation. >>>>> + */ >>>>> +/dts-v1/; >>>>> +#include "stih416.dtsi" >>>>> +#include "stih41x-b2020.dtsi" >>>>> +/ { >>>>> + model = "STiH416 B2020 REV-E"; >>>>> + compatible = "st,stih416-b2020", "st,stih416"; >>>>> + >>>>> + soc { >>>>> + miphy365x_phy: miphy365x at fe382000 { >>>>> + st,pcie-tx-pol-inv; >>>>> + st,sata-gen = <3>; >>>>> + }; >>>>> + }; >>>>> +}; >>>> Shouldn't this new board being added in a separate patch? >>> >>> I certainly can do that, but I don't think that it's necessary? >> >> I think it is, as you introduce a new board. > > Introducing an empty dts file just so you can say "this is a new > board" seems odd to me, but I'll go with whatever you feel it right. > >> Moreover, the miphy description being the same as in >> stih416-b2020.dts, so I don't understand why you introduce this >> board for this feature. > > It's historical. There are other differences between rev-E and the > other reversions, such as; gpio-leds (red, green) and the reset GPIO > for ethernet. As these are dts files (rather than dtsi) files, you > can only use one at a time. My point was to create a new patch that would also introduce the differences (Ethernet, leds...). The commit message would explain the differences versus stih416-b2020. From your patch, if I didn't know the differences, I would ask why you don't use stih416-b2020.dts. If you have another pending patch that make Ethernet to work on revE board, you can keep this one as it is. > >>>>> diff --git a/arch/arm/boot/dts/stih416-b2020.dts b/arch/arm/boot/dts/stih416-b2020.dts >>>>> index 276f28d..172f222 100644 >>>>> --- a/arch/arm/boot/dts/stih416-b2020.dts >>>>> +++ b/arch/arm/boot/dts/stih416-b2020.dts >>>>> @@ -13,4 +13,10 @@ >>>>> model = "STiH416 B2020"; >>>>> compatible = "st,stih416", "st,stih416-b2020"; >>>>> >>>>> + soc { >>>>> + miphy365x_phy: miphy365x at fe382000 { >>>>> + st,pcie-tx-pol-inv; >>>>> + st,sata-gen = <3>; >>>>> + }; >>>>> + }; >>>>> }; >>>> ... >>> >