From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] Fix for possible null pointer dereference in dma.c
Date: Tue, 20 May 2014 21:31:57 +0200 [thread overview]
Message-ID: <537BADAD.5070904@gmail.com> (raw)
In-Reply-To: <20140520192958.GE6639@foghorn.codeweavers.com>
On 20.05.2014 21:29, Andrew Eikum wrote:
> On Tue, May 20, 2014 at 09:16:59PM +0200, Tomasz Figa wrote:
>> To me having NULL as either data argument of buffer done callback or
>> private_data would be a serious driver bug and IMHO it's better to let
>> it crash with a NULL pointer dereference to let someone notice than mask
>> it by adding a condition.
>>
>
> Please, no. Regardless of who is at fault, crashes in library code
> are insanely frustrating to application developers. Error codes can
> be handled nicely and expressed to the user as an error message.
> Crashes are hideous for end users and usually end up being support
> nightmares for developers.
How is the related code a library?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-20 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 21:57 [PATCH] Fix for possible null pointer dereference in dma.c Rickard Strandqvist
2014-05-19 5:39 ` Lothar Waßmann
2014-05-19 10:52 ` Tomasz Figa
2014-05-20 19:12 ` Rickard Strandqvist
2014-05-20 19:16 ` Tomasz Figa
2014-05-20 19:29 ` [alsa-devel] " Andrew Eikum
2014-05-20 19:31 ` Tomasz Figa [this message]
2014-05-20 21:21 ` Lars-Peter Clausen
2014-05-20 21:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537BADAD.5070904@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).