From: ivan.khoronzhuk@ti.com (Ivan Khoronzhuk)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v4 4/5] ARM: dts: keystone: update reset node to work with reset driver
Date: Wed, 21 May 2014 19:05:21 +0300 [thread overview]
Message-ID: <537CCEC1.1070801@ti.com> (raw)
In-Reply-To: <15259908.YoiO6LMEzV@wuerfel>
On 05/21/2014 05:50 PM, Arnd Bergmann wrote:
> On Wednesday 21 May 2014 17:27:33 Ivan Khoronzhuk wrote:
>> The keystone driver requires the next additional properties:
>>
>> "ti,syscon-pll" - syscon register range used to access pll controller
>> registers in order to use reset control registers.
>> "ti,syscon-dev" - syscon register range used to access device state
>> control registers in order to use mux block
>> registers for all watchdogs.
>>
>> "ti,wdt_list" - option to declare what watchdog are used to reboot
>> the SoC, so set "0" WDT as default.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> Same comment as what I had for the binding: it's not a register range
> any more, but a phandle for a device.
>
>> ---
>> arch/arm/boot/dts/keystone.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index 8b899ba..783da60 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -78,7 +78,9 @@
>>
>> rstctrl: reset-controller {
>> compatible = "ti,keystone-reset";
>> - reg = <0x023100e8 4>; /* pll reset control reg */
>> + ti,syscon-pll = <&pllctrl>;
>> + ti,syscon-dev = <&devctrl>;
>> + ti,wdt_list = <0>;
>> };
>>
> I don't see a definition for the two labels, so this will cause a
> build error. It makes sense to add them in the same patch.
>
> Arnd
Thanks,
I'll correct
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2014-05-21 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 14:27 [Patch v4 0/5] Introduce keystone reset driver Ivan Khoronzhuk
2014-05-21 14:27 ` [Patch v4 1/5] Power: reset: keystone-reset: introduce " Ivan Khoronzhuk
2014-05-21 14:27 ` [Patch v4 2/5] Power: reset: add bindings for " Ivan Khoronzhuk
2014-05-21 14:50 ` Arnd Bergmann
2014-05-21 16:03 ` Ivan Khoronzhuk
2014-05-21 16:07 ` Arnd Bergmann
2014-05-21 16:09 ` Santosh Shilimkar
2014-05-21 14:27 ` [Patch v4 3/5] ARM: keystone: remove redundant reset stuff Ivan Khoronzhuk
2014-05-21 14:27 ` [Patch v4 4/5] ARM: dts: keystone: update reset node to work with reset driver Ivan Khoronzhuk
2014-05-21 14:50 ` Arnd Bergmann
2014-05-21 16:05 ` Ivan Khoronzhuk [this message]
2014-05-21 14:27 ` [Patch v4 5/5] ARM: keystone: enable reset driver support Ivan Khoronzhuk
2014-05-21 14:52 ` [Patch v4 0/5] Introduce keystone reset driver Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CCEC1.1070801@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).