From: jay.aurabind@gmail.com (Jay Aurabind)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: abx500-core: Remove unused function abx500_dump_all_banks()
Date: Thu, 22 May 2014 16:06:43 +0530 [thread overview]
Message-ID: <537DD33B.6070401@gmail.com> (raw)
In-Reply-To: <1400750311-15323-1-git-send-email-lee.jones@linaro.org>
On 05/22/2014 02:48 PM, Lee Jones wrote:
> abx500_dump_all_banks() has no callers in the kernel, so it's probably
> safe to remove it.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/abx500-core.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
> index d6d0ec4..fe41899 100644
> --- a/drivers/mfd/abx500-core.c
> +++ b/drivers/mfd/abx500-core.c
> @@ -151,26 +151,6 @@ int abx500_startup_irq_enabled(struct device *dev, unsigned int irq)
> }
> EXPORT_SYMBOL(abx500_startup_irq_enabled);
>
> -int abx500_dump_all_banks(void)
> -{
> - struct abx500_ops *ops;
> - struct device *dummy_child;
> - struct abx500_device_entry *dev_entry;
> -
> - dummy_child = kzalloc(sizeof(struct device), GFP_KERNEL);
> - if (!dummy_child)
> - return -ENOMEM;
> - list_for_each_entry(dev_entry, &abx500_list, list) {
> - dummy_child->parent = dev_entry->dev;
> - ops = &dev_entry->ops;
> -
> - if ((ops != NULL) && (ops->dump_all_banks != NULL))
> - ops->dump_all_banks(dummy_child);
> - }
> - kfree(dummy_child);
> -}
> -EXPORT_SYMBOL(abx500_dump_all_banks);
> -
> MODULE_AUTHOR("Mattias Wallin <mattias.wallin@stericsson.com>");
> MODULE_DESCRIPTION("ABX500 core driver");
> MODULE_LICENSE("GPL");
>
Sorry for top posting previously, I was using gmail web interface. Looks
like you forgot to remove this function's declaration from
include/linux/mfd/abx500.h
next prev parent reply other threads:[~2014-05-22 10:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 9:18 [PATCH] mfd: abx500-core: Remove unused function abx500_dump_all_banks() Lee Jones
2014-05-22 9:18 ` [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[] Lee Jones
2014-05-22 15:59 ` Joe Perches
2014-05-22 16:08 ` Lee Jones
2014-05-22 16:45 ` Joe Perches
2014-05-23 11:43 ` Lee Jones
2014-05-22 9:18 ` [PATCH] mfd: max14577: Cast to architecture agnostic data type Lee Jones
2014-05-22 10:36 ` Jay Aurabind [this message]
2014-05-22 10:51 ` [PATCH] mfd: abx500-core: Remove unused function abx500_dump_all_banks() Lee Jones
2014-05-22 11:30 ` [PATCH v2] " Lee Jones
2014-05-22 22:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537DD33B.6070401@gmail.com \
--to=jay.aurabind@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).