* [Patch] ARM: dts: keystone: add pll controller syscon entry
@ 2014-05-21 14:17 Ivan Khoronzhuk
2014-05-21 14:56 ` Ivan Khoronzhuk
2014-05-21 18:18 ` Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Ivan Khoronzhuk @ 2014-05-21 14:17 UTC (permalink / raw)
To: linux-arm-kernel
The pll controller register set includes sets of registers with
different purposes, so it's logically to add syscon entry to be able
to access them from appropriate places.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
---
Based on linux-next/master
arch/arm/boot/dts/keystone.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index d9f99e7..5e67c5b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -66,6 +66,11 @@
ranges = <0x0 0x0 0x0 0xc0000000>;
dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
+ pllctrl: pll_controller {
+ compatible = "ti,keystone-pllctrl", "syscon";
+ reg = <0x2310000 0x200>;
+ };
+
rstctrl: reset-controller {
compatible = "ti,keystone-reset";
reg = <0x023100e8 4>; /* pll reset control reg */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Patch] ARM: dts: keystone: add pll controller syscon entry
2014-05-21 14:17 [Patch] ARM: dts: keystone: add pll controller syscon entry Ivan Khoronzhuk
@ 2014-05-21 14:56 ` Ivan Khoronzhuk
2014-05-21 18:18 ` Sergei Shtylyov
1 sibling, 0 replies; 5+ messages in thread
From: Ivan Khoronzhuk @ 2014-05-21 14:56 UTC (permalink / raw)
To: linux-arm-kernel
Ignore this. It'll be included in "Introduce keystone reset driver"
patch series
On 05/21/2014 05:17 PM, Ivan Khoronzhuk wrote:
> The pll controller register set includes sets of registers with
> different purposes, so it's logically to add syscon entry to be able
> to access them from appropriate places.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
>
> Based on linux-next/master
>
> arch/arm/boot/dts/keystone.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
> index d9f99e7..5e67c5b 100644
> --- a/arch/arm/boot/dts/keystone.dtsi
> +++ b/arch/arm/boot/dts/keystone.dtsi
> @@ -66,6 +66,11 @@
> ranges = <0x0 0x0 0x0 0xc0000000>;
> dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
>
> + pllctrl: pll_controller {
> + compatible = "ti,keystone-pllctrl", "syscon";
> + reg = <0x2310000 0x200>;
> + };
> +
> rstctrl: reset-controller {
> compatible = "ti,keystone-reset";
> reg = <0x023100e8 4>; /* pll reset control reg */
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 5+ messages in thread* [Patch] ARM: dts: keystone: add pll controller syscon entry
2014-05-21 14:17 [Patch] ARM: dts: keystone: add pll controller syscon entry Ivan Khoronzhuk
2014-05-21 14:56 ` Ivan Khoronzhuk
@ 2014-05-21 18:18 ` Sergei Shtylyov
2014-05-21 18:22 ` Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2014-05-21 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 05/21/2014 06:17 PM, Ivan Khoronzhuk wrote:
> The pll controller register set includes sets of registers with
> different purposes, so it's logically to add syscon entry to be able
> to access them from appropriate places.
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
> Based on linux-next/master
> arch/arm/boot/dts/keystone.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
> index d9f99e7..5e67c5b 100644
> --- a/arch/arm/boot/dts/keystone.dtsi
> +++ b/arch/arm/boot/dts/keystone.dtsi
> @@ -66,6 +66,11 @@
> ranges = <0x0 0x0 0x0 0xc0000000>;
> dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
>
> + pllctrl: pll_controller {
I think it's better to follow the pattern established by "reset-controller"
and use hyphen ISO dash in the node name. This is also a common practice to
use hyphens in the device trees overall.
> + compatible = "ti,keystone-pllctrl", "syscon";
> + reg = <0x2310000 0x200>;
> + };
> +
> rstctrl: reset-controller {
> compatible = "ti,keystone-reset";
> reg = <0x023100e8 4>; /* pll reset control reg */
>
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* [Patch] ARM: dts: keystone: add pll controller syscon entry
2014-05-21 18:18 ` Sergei Shtylyov
@ 2014-05-21 18:22 ` Sergei Shtylyov
2014-05-22 13:51 ` Ivan Khoronzhuk
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2014-05-21 18:22 UTC (permalink / raw)
To: linux-arm-kernel
On 05/21/2014 10:18 PM, Sergei Shtylyov wrote:
>> The pll controller register set includes sets of registers with
>> different purposes, so it's logically to add syscon entry to be able
>> to access them from appropriate places.
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>> Based on linux-next/master
>> arch/arm/boot/dts/keystone.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index d9f99e7..5e67c5b 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -66,6 +66,11 @@
>> ranges = <0x0 0x0 0x0 0xc0000000>;
>> dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
>>
>> + pllctrl: pll_controller {
> I think it's better to follow the pattern established by "reset-controller"
> and use hyphen ISO dash in the node name. This is also a common practice to
Oops, hyphen and dash are basically the same thing; I meant
s/dash/underscore/.
> use hyphens in the device trees overall.
>> + compatible = "ti,keystone-pllctrl", "syscon";
>> + reg = <0x2310000 0x200>;
>> + };
>> +
>> rstctrl: reset-controller {
>> compatible = "ti,keystone-reset";
>> reg = <0x023100e8 4>; /* pll reset control reg */
>>
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* [Patch] ARM: dts: keystone: add pll controller syscon entry
2014-05-21 18:22 ` Sergei Shtylyov
@ 2014-05-22 13:51 ` Ivan Khoronzhuk
0 siblings, 0 replies; 5+ messages in thread
From: Ivan Khoronzhuk @ 2014-05-22 13:51 UTC (permalink / raw)
To: linux-arm-kernel
On 05/21/2014 09:22 PM, Sergei Shtylyov wrote:
> On 05/21/2014 10:18 PM, Sergei Shtylyov wrote:
>
>>> The pll controller register set includes sets of registers with
>>> different purposes, so it's logically to add syscon entry to be able
>>> to access them from appropriate places.
>
>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>> ---
>
>>> Based on linux-next/master
>
>>> arch/arm/boot/dts/keystone.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>
>>> diff --git a/arch/arm/boot/dts/keystone.dtsi
>>> b/arch/arm/boot/dts/keystone.dtsi
>>> index d9f99e7..5e67c5b 100644
>>> --- a/arch/arm/boot/dts/keystone.dtsi
>>> +++ b/arch/arm/boot/dts/keystone.dtsi
>>> @@ -66,6 +66,11 @@
>>> ranges = <0x0 0x0 0x0 0xc0000000>;
>>> dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
>>>
>>> + pllctrl: pll_controller {
>
>> I think it's better to follow the pattern established by
>> "reset-controller"
>> and use hyphen ISO dash in the node name. This is also a common
>> practice to
>
> Oops, hyphen and dash are basically the same thing; I meant
> s/dash/underscore/.
You meant s/underscore/dash.
I'll replace.
FYI: the change is included in new series [Patch v5 0/7] Introduce
keystone reset driver
And this patch is squashed in:
[Patch v5 6/7] ARM: dts: keystone: update reset node to work with reset
driver
Thanks.
>
>> use hyphens in the device trees overall.
>
>>> + compatible = "ti,keystone-pllctrl", "syscon";
>>> + reg = <0x2310000 0x200>;
>>> + };
>>> +
>>> rstctrl: reset-controller {
>>> compatible = "ti,keystone-reset";
>>> reg = <0x023100e8 4>; /* pll reset control reg */
>>>
>
> WBR, Sergei
>
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-22 13:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21 14:17 [Patch] ARM: dts: keystone: add pll controller syscon entry Ivan Khoronzhuk
2014-05-21 14:56 ` Ivan Khoronzhuk
2014-05-21 18:18 ` Sergei Shtylyov
2014-05-21 18:22 ` Sergei Shtylyov
2014-05-22 13:51 ` Ivan Khoronzhuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).