From: cov@codeaurora.org (Christopher Covington)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ARM: tty: Move HVC DCC assembly to arch/arm
Date: Thu, 22 May 2014 18:05:53 -0400 [thread overview]
Message-ID: <537E74C1.7020509@codeaurora.org> (raw)
In-Reply-To: <52617F22.6030900@codeaurora.org>
Hi Stephen,
On 10/18/2013 02:34 PM, Stephen Boyd wrote:
> On 10/18/13 11:14, Christopher Covington wrote:
>> Put architecture-specific assembly code where it belongs,
>> allowing for support of additional architectures such as arm64 in
>> the future.
>
> Do you have that patch too? There was also a patch a year ago to add
> armv5/v4 support to this driver. Maybe we can resurrect that too.
I still haven't gotten around to testing that one.
>> diff --git a/drivers/tty/hvc/hvc_dcc.c b/drivers/tty/hvc/hvc_dcc.c
>> index 44fbeba..e9f0191 100644
>> --- a/drivers/tty/hvc/hvc_dcc.c
>> +++ b/drivers/tty/hvc/hvc_dcc.c
>> @@ -8,57 +8,13 @@
>> * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> * GNU General Public License for more details.
>> - *
>> - * You should have received a copy of the GNU General Public License
>> - * along with this program; if not, write to the Free Software
>> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
>> - * 02110-1301, USA.
>> */
>>
>> -#include <linux/console.h>
>> -#include <linux/delay.h>
>> -#include <linux/err.h>
>> -#include <linux/init.h>
>
> We still need init.h
Fixed in v2.
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2014-05-22 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 18:14 [RFC] ARM: tty: Move HVC DCC assembly to arch/arm Christopher Covington
2013-10-18 18:34 ` Stephen Boyd
2014-05-22 22:05 ` Christopher Covington [this message]
2014-05-22 22:18 ` Stephen Boyd
2013-10-23 5:59 ` Kumar Gala
2014-05-22 22:06 ` Christopher Covington
2014-05-22 22:07 ` [PATCH v2] " Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537E74C1.7020509@codeaurora.org \
--to=cov@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).