From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings
Date: Fri, 23 May 2014 11:54:31 +0200 [thread overview]
Message-ID: <537F1AD7.1070808@samsung.com> (raw)
In-Reply-To: <20140522184656.GS12304@sirena.org.uk>
On 22/05/14 20:46, Mark Brown wrote:
> On Thu, May 22, 2014 at 01:55:07PM +0200, Sylwester Nawrocki wrote:
>
>> + sound {
>> + compatible = "samsung,odroidx2-audio";
>> + samsung,i2s-controller = <&i2s0>;
>> + samsung,audio-codec = <&max98090>;
>> + };
>
> Can this not use simple-card?
I dug into that and it seems it almost could, but there is one
thing I'm not sure how to cover with the simple-card DT bindings
and the related driver.
There are these two calls:
+ ret = snd_soc_dai_set_sysclk(cpu_dai, SAMSUNG_I2S_OPCLK,
+ 0, MOD_OPCLK_PCLK);
+ /* Set the cpu DAI configuration in order to use CDCLK */
+ ret = snd_soc_dai_set_sysclk(cpu_dai, SAMSUNG_I2S_CDCLK,
+ 0, SND_SOC_CLOCK_OUT);
This changes clocks routing so that the CPU DAI in slave mode generates
master clock for the codec, on the SoC's CDCLK pin. Then this is
a reference clock for the codec's PLL, which is a source of the I2S
interface clocks.
It's done this way to avoid changing at runtime frequency of the EPLL
clock, which may be parent of other clocks than the sound subsystem,
e.g. MMC.
simple-card just calls set_sysclk once for the CPU DAI and CODEC with
the second and last argument set to 0.
I'll try and see again if there is some way to use simple-card.
--
Thanks,
Sylwester
prev parent reply other threads:[~2014-05-23 9:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 11:55 [PATCH 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings Sylwester Nawrocki
2014-05-22 11:55 ` [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2 Sylwester Nawrocki
2014-05-22 18:53 ` Mark Brown
2014-05-23 8:44 ` Sylwester Nawrocki
2014-05-23 11:05 ` Mark Brown
2014-07-04 11:04 ` Sylwester Nawrocki
2014-07-04 11:10 ` [alsa-devel] " Lars-Peter Clausen
2014-07-04 11:24 ` Sylwester Nawrocki
2014-07-04 11:28 ` Lars-Peter Clausen
2014-05-22 18:46 ` [PATCH 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings Mark Brown
2014-05-23 9:54 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537F1AD7.1070808@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox