public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 05/12] doc/bindings: Update Layerscape PCIe devicetree binding to be more flexible
Date: Thu, 15 Oct 2015 16:16:57 +0200	[thread overview]
Message-ID: <5383901.aC2HYopUNW@wuerfel> (raw)
In-Reply-To: <1444891672-32117-6-git-send-email-bhupesh.sharma@freescale.com>

On Thursday 15 October 2015 12:17:45 Bhupesh Sharma wrote:
> 
> +Note that since this controller derives its clocks from the Reset
> +Configuration Word (RCW) which is used to describe the PLL settings at
> +the time of chip-reset, the 'clocks' and 'clock-names' properties from
> +'designware-pcie.txt' are optional for this controller.

If this is an option for the dw-pcie block, should this description be
added to the generic binding instead?

> +Also as per the available Reference Manuals, there is no specific 'version'
> +register available in the Freescale PCIe controller register set,
> +which can allow determining the underlying Designware PCIe controller version
> +information.
> +
>  Required properties:
> -- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
> +- compatible: should contain the platform identifier such as "fsl,<soc-name>-pcie",
> +  "snps,dw-pcie".

You should document all the strings that will be needed here, otherwise a
driver write does not know what to look for.

If two chips have a 100% identical PCIe implementation, just use the string
of the older chip for both.

	Arnd

  reply	other threads:[~2015-10-15 14:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15  6:47 [PATCH v3 00/12] ARM64: Update support for FSL's LS2085A SoC Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 01/12] arm64: Use generic Layerscape SoC family naming Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 02/12] arm64: Rename FSL LS2085A SoC support code to LS2080A Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 03/12] Documentation: DT: Add entry for FSL LS2080A QDS and RDB boards Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 04/12] Documentation/dts: Move FSL board-specific bindings out of /powerpc Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 05/12] doc/bindings: Update Layerscape PCIe devicetree binding to be more flexible Bhupesh Sharma
2015-10-15 14:16   ` Arnd Bergmann [this message]
2015-10-15 20:11     ` Sharma Bhupesh
2015-10-28  3:57       ` Pratyush Anand
2015-10-15  6:47 ` [PATCH v3 06/12] doc/bindings: Update GPIO devicetree binding documentation for LS2080A Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 07/12] doc: DTS: Update DWC3 binding to provide reference to generic bindings Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 08/12] dts/ls2080a: Update DTSI to add support of various peripherals Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 09/12] dts/ls2080a: Update Simulator DTS " Bhupesh Sharma
2015-10-15 14:18   ` Arnd Bergmann
2015-10-15 20:01     ` Sharma Bhupesh
2015-10-15  6:47 ` [PATCH v3 10/12] dts/ls2080a: Remove text about writing to Free Software Foundation Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 11/12] dts/ls2080a: Add DTS support for LS2080a QDS & RDB boards Bhupesh Sharma
2015-10-15  6:47 ` [PATCH v3 12/12] dts/Makefile: Add build support for LS2080a QDS & RDB board DTS Bhupesh Sharma
2015-10-15 14:19   ` Arnd Bergmann
2015-10-15 19:58     ` Sharma Bhupesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5383901.aC2HYopUNW@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox