linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/7] of: configure the platform device dma parameters
Date: Wed, 28 May 2014 10:04:16 -0400	[thread overview]
Message-ID: <5385ECE0.7040703@ti.com> (raw)
In-Reply-To: <CACRpkda5x-fJWTN40ze17woMWuWoVbuhbNu5nkm1sFcdJchRfA@mail.gmail.com>

On Wednesday 28 May 2014 09:32 AM, Linus Walleij wrote:
> On Wed, May 28, 2014 at 3:29 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Wednesday 28 May 2014 10:23:09 Linus Walleij wrote:
> 
>>>         model = "ARM Integrator/AP";
>>>         compatible = "arm,integrator-ap";
>>> +       dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
>>>
>>>         aliases {
>>>                 arm,timer-primary = &timer2;
>>>
>>
>> It looks like you accidentally copied the ranges from keystone, even
>> though that has a 64-bit root bus and you only have 32-bit.
> 
> Nah it was no accident, just good old incompetence ;-)
> 
>> I suspect what you want is
>>
>>         dma-ranges = <0x80000000 0 0x80000000>;
>>
>> to translate dma_addr_t 0x80000000-0xffffffff to phys_addr_t 0x0-0x7fffffff
>> rather than phys_addr_t 0x800000000-0x87fffffff.
>
Interesting. Where does the ROM address space resides on integrator then considering
address 0 is used for DMA.
 
> Thanks, I'll fix up my patch.
> 
Feel free to add my ack after the fixup if you need one.

regards,
Santosh

  reply	other threads:[~2014-05-28 14:04 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 15:30 [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 1/7] device: introduce per device dma_pfn_offset Santosh Shilimkar
2014-05-02  1:01   ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 2/7] of: introduce of_dma_get_range() helper Santosh Shilimkar
2014-05-02  1:06   ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 3/7] of: introduce of_dma_is_coherent() helper Santosh Shilimkar
2014-05-02  0:56   ` Rob Herring
2014-05-05 21:45     ` Santosh Shilimkar
2014-05-05 22:06       ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 4/7] of: configure the platform device dma parameters Santosh Shilimkar
2014-04-29 14:41   ` Grant Likely
2014-04-30 14:19     ` Santosh Shilimkar
2014-05-01 13:12       ` Grant Likely
2014-05-01 13:16         ` Santosh Shilimkar
2014-05-02  9:58         ` Arnd Bergmann
2014-05-02 13:13           ` Santosh Shilimkar
2014-05-02 15:13             ` Arnd Bergmann
2014-05-27 12:56           ` Grant Likely
2014-05-27 13:30             ` Arnd Bergmann
2014-05-28  8:23               ` Linus Walleij
2014-05-28 13:29                 ` Arnd Bergmann
2014-05-28 13:32                   ` Linus Walleij
2014-05-28 14:04                     ` Santosh Shilimkar [this message]
2014-05-29 14:01                       ` Linus Walleij
2014-05-29 14:08                         ` Santosh Shilimkar
2014-05-29 19:24                           ` Arnd Bergmann
2014-05-29 20:04                             ` Santosh Shilimkar
2014-05-02  0:49   ` Rob Herring
2014-05-05 21:47     ` Santosh Shilimkar
2014-05-05 22:08       ` Rob Herring
2014-05-06  9:40       ` Arnd Bergmann
2014-05-06 20:44         ` Santosh Shilimkar
2014-05-07 13:24           ` Santosh Shilimkar
2014-05-02 16:54   ` Bjorn Helgaas
2014-05-02 18:59     ` Arnd Bergmann
2014-05-05 20:45       ` Bjorn Helgaas
2014-05-05 20:55         ` Arnd Bergmann
2014-05-05 22:28           ` Bjorn Helgaas
2014-05-06  3:44             ` Benjamin Herrenschmidt
2014-05-06  9:54               ` Arnd Bergmann
2014-05-06 13:32                 ` Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 5/7] ARM: dma: Use dma_pfn_offset for dma address translation Santosh Shilimkar
2014-05-02 14:32   ` Rob Herring
2014-05-02 14:58   ` Russell King - ARM Linux
2014-05-02 15:05     ` Santosh Shilimkar
2014-05-05 19:50       ` Russell King - ARM Linux
2014-05-05 21:43         ` Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 6/7] ARM: dma: implement set_arch_dma_coherent_ops() Santosh Shilimkar
2014-05-02  0:58   ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 7/7] ARM: dma: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu] Santosh Shilimkar
2014-04-24 15:45   ` Will Deacon
2014-05-01 13:19 ` [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-05-01 13:25   ` Russell King - ARM Linux
2014-05-01 14:06     ` Santosh Shilimkar
2014-05-02 14:41     ` Rob Herring
2014-05-02 16:41       ` Santosh Shilimkar
2014-05-14 10:12     ` Grant Likely
2014-06-02  6:37 ` Shawn Guo
2014-06-02 13:24   ` Santosh Shilimkar
2014-06-02 15:06     ` Arnd Bergmann
2014-06-02 15:54       ` Santosh Shilimkar
2014-06-02 19:00         ` Arnd Bergmann
2014-06-02 19:08           ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5385ECE0.7040703@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).