From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: vt8500: Staticize local symbols
Date: Fri, 30 May 2014 08:44:15 +1200 [thread overview]
Message-ID: <53879C1F.1060804@prisktech.co.nz> (raw)
In-Reply-To: <4308955.HrfvHXcbAr@wuerfel>
On 28/05/14 00:05, Arnd Bergmann wrote:
> On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
>> Variables local to this file are made static.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> arch/arm/mach-vt8500/vt8500.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Looks good to me, but you forgot to take the maintainer on Cc.
>
> How should we handle this patch? I guess this is the only one
> for vt8500 in 3.16, so I can pick it up directly with Tony's
> Ack.
>
>> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
>> index 4a73464cb11b..2da7be31e7e2 100644
>> --- a/arch/arm/mach-vt8500/vt8500.c
>> +++ b/arch/arm/mach-vt8500/vt8500.c
>> @@ -44,7 +44,7 @@
>>
>> static void __iomem *pmc_base;
>>
>> -void vt8500_restart(enum reboot_mode mode, const char *cmd)
>> +static void vt8500_restart(enum reboot_mode mode, const char *cmd)
>> {
>> if (pmc_base)
>> writel(1, pmc_base + VT8500_PMSR_REG);
>> @@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
>> },
>> };
>>
>> -void __init vt8500_map_io(void)
>> +static void __init vt8500_map_io(void)
>> {
>> iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
>> }
>> @@ -72,7 +72,7 @@ static void vt8500_power_off(void)
>> asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>> }
>>
>> -void __init vt8500_init(void)
>> +static void __init vt8500_init(void)
>> {
>> struct device_node *np;
>> #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
>>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Can you pick this up please Arnd? Doesn't look like there will be
anything else for 3.16
Regards
Tony P
next prev parent reply other threads:[~2014-05-29 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 11:57 [PATCH 1/1] ARM: vt8500: Staticize local symbols Sachin Kamat
2014-05-27 12:05 ` Arnd Bergmann
2014-05-29 20:44 ` Tony Prisk [this message]
2014-05-30 6:19 ` Sachin Kamat
2014-05-30 14:53 ` Arnd Bergmann
2014-05-30 17:03 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53879C1F.1060804@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).