From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix debug prints relevant to PCI devices
Date: Wed, 04 Jun 2014 23:32:48 +0400 [thread overview]
Message-ID: <538F7460.6020600@cogentembedded.com> (raw)
In-Reply-To: <1401909447-8434-1-git-send-email-vidyas@nvidia.com>
Hello.
On 06/04/2014 11:17 PM, Vidya Sagar wrote:
> As per PCIe spec, fast back-to-back transactions feature
> is not applicable to PCIe devices. Hence, do not print
> that fast back-to-back trasactions are disabled when
> there is a PCIe device found on the bus
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> arch/arm/kernel/bios32.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
> diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> index 17a26c1..95ad3fb 100644
> --- a/arch/arm/kernel/bios32.c
> +++ b/arch/arm/kernel/bios32.c
[...]
> @@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
>
> /*
> * Report what we did for this bus
> + * (only if the bus doesn't have even one PCIe device)
> */
> - printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
> - bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
> + if (!has_pcie_dev)
> + printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
Time to change this to pr_info()...
> + bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
> }
> EXPORT_SYMBOL(pcibios_fixup_bus);
WBR, Sergei
prev parent reply other threads:[~2014-06-04 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 19:17 [PATCH] ARM: fix debug prints relevant to PCI devices Vidya Sagar
2014-06-04 19:29 ` Stephen Warren
2014-06-04 21:04 ` Jason Gunthorpe
2014-06-04 23:46 ` Russell King - ARM Linux
2014-06-04 19:32 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F7460.6020600@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).