From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ACPICA: Only include ACPI asm files if ACPI is enabled
Date: Thu, 05 Jun 2014 12:11:21 +0800 [thread overview]
Message-ID: <538FEDE9.4010603@linaro.org> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E880262042C@SHSMSX101.ccr.corp.intel.com>
On 2014-6-5 9:14, Zheng, Lv wrote:
> Hi, Lee
>
>> From: Lee Jones [mailto:lee.jones at linaro.org]
>> Sent: Wednesday, June 04, 2014 8:52 PM
>> To: Rafael J. Wysocki
>>
>> On Wed, 04 Jun 2014, Rafael J. Wysocki wrote:
>>
>>> On Wednesday, June 04, 2014 01:09:50 PM Lee Jones wrote:
>>>> Any drivers which support ACPI and Device Tree probing need to include
>>>> both respective header files. Without this patch, if a driver is being
>>>> used on a platform which does not support ACPI and subsequently does not
>>>> have the config option enabled, but includes linux/acpi.h the build
>>>> breaks with:
>>>>
>>>> In file included from ../include/acpi/platform/acenv.h:150:0,
>>>> from ../include/acpi/acpi.h:56,
>>>> from ../include/linux/match.h:2,
>>>> from ../drivers/i2c/i2c-core.c:43:
>>>> ../include/acpi/platform/aclinux.h:73:23:
>>>> fatal error: asm/acenv.h: No such file or directory
>>>> #include <asm/acenv.h>
>>>> ^
>
> Note that:
> In our tree:
> <asm/acenv.h> is only included by <acpi/acpi.h>.
> And <acpi/acpi.h> is only included by
> 1. <linux/acpi.h> when CONFIG_ACPI enabled
> 2. <linux/sfi_acpi.h> - this is x86 specific, we'll clean it up by implementing stubs for all ACPI external interfaces.
> So there is no case we need to exclude <asm/acenv.h> when CONFIG_ACPI is not enabled.
>
> I cannot find linux/match.h here.
> If <linux/match.h> want to include ACPI features, it shouldn't include <acpi/acpi.h>, but should include <linux/acpi.h>.
> Please refer to:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8b48463f
> And stop including <acpi/acpi.h> directly in any cases.
Ah, I agree, please ignore my previous email,
sorry for the noise.
Since it is very important to include <linux/acpi.h> but not <acpi/acpi.h>,
can we document it somewhere as the guidance? Then people will not
make such mistake :)
Thanks
Hanjun
next prev parent reply other threads:[~2014-06-05 4:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 12:09 [PATCH 0/7] i2c: Relax mandatory I2C ID table passing Lee Jones
2014-06-04 12:09 ` [PATCH 1/7] ACPICA: Only include ACPI asm files if ACPI is enabled Lee Jones
2014-06-04 12:35 ` Rafael J. Wysocki
2014-06-04 12:51 ` Lee Jones
2014-06-04 21:29 ` Rafael J. Wysocki
2014-06-05 1:01 ` Zheng, Lv
2014-06-05 1:14 ` Zheng, Lv
2014-06-05 4:11 ` Hanjun Guo [this message]
2014-06-05 4:46 ` Zheng, Lv
2014-06-05 0:56 ` Zheng, Lv
2014-06-05 4:06 ` Hanjun Guo
2014-06-04 12:09 ` [PATCH 2/7] i2c: Add pointer dereference protection to i2c_match_id() Lee Jones
2014-06-04 12:09 ` [PATCH 3/7] i2c: Add the ability to match device to compatible string without an of_node Lee Jones
2014-06-04 17:29 ` Rob Herring
2014-06-04 17:55 ` Lee Jones
2014-06-05 17:36 ` Grant Likely
2014-06-06 8:10 ` Lee Jones
2014-06-06 23:39 ` Grant Likely
2014-06-04 12:09 ` [PATCH 4/7] i2c: Match using traditional OF methods, then by vendor-less compatible strings Lee Jones
2014-06-04 12:09 ` [PATCH 5/7] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices Lee Jones
2014-06-05 10:27 ` Grant Likely
2014-06-04 12:09 ` [PATCH 6/7] of/device: Allow I2C devices to OF match without supplying an OF node Lee Jones
2014-06-04 12:09 ` [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems Lee Jones
2014-06-04 12:37 ` Rafael J. Wysocki
2014-06-04 12:51 ` Mika Westerberg
2014-06-04 13:28 ` Lee Jones
2014-06-05 8:00 ` Mika Westerberg
2014-06-05 8:20 ` Lee Jones
2014-06-05 10:32 ` Grant Likely
2014-06-05 10:30 ` Grant Likely
2014-06-05 10:37 ` Lee Jones
2014-06-05 15:41 ` Grant Likely
2014-06-05 15:55 ` Lee Jones
2014-06-05 17:37 ` Grant Likely
2014-06-06 10:24 ` Mark Brown
2014-06-06 12:36 ` Lee Jones
2014-06-06 23:42 ` Grant Likely
2014-06-07 9:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538FEDE9.4010603@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).