From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/2] [RFC] ASoC: samsung: move s3c24xx over to dmaengine
Date: Thu, 05 Jun 2014 15:29:21 +0200 [thread overview]
Message-ID: <539070B1.8070404@metafoo.de> (raw)
In-Reply-To: <6123933.aGtaUr149J@wuerfel>
On 06/05/2014 03:20 PM, Arnd Bergmann wrote:
> The s3c24xx sound support keeps giving randconfig build errors, this
> is a new attempt to solve it by moving the driver over to use dmaengine
> exclusively.
>
> The removal of the legacy DMA support and the addition of the
> s3c24xx_dma_filter pointer are fairly obvious here. The part I'm not
> completely sure about is the removal of the s3c2410_dma_ctrl(...,
> S3C2410_DMAOP_STARTED) and dma_data->ops->started() calls. My understanding
> is that these are only required for drivers that do not support cyclic
> transfers, which the new dma engine driver now does, so we can simply
> remove them. This would also fix at least one bug in the ac97 driver
> on newer machines, which currently gives us a NULL pointer dereference
> from trying to call dma_data->ops->started().
>
> Any insights about this, or testing would be very welcome.
>
There is already a very similar patch for this, see:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-June/077327.html
I think that one is scheduled to be merged.
- Lars
next prev parent reply other threads:[~2014-06-05 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 13:20 [PATCH 1/2] [RFC] ASoC: samsung: move s3c24xx over to dmaengine Arnd Bergmann
2014-06-05 13:23 ` [PATCH 2/2] [RFC] ASoC: samsung: remove unused DMA data Arnd Bergmann
2014-06-05 13:29 ` Lars-Peter Clausen [this message]
2014-06-05 13:36 ` [PATCH 1/2] [RFC] ASoC: samsung: move s3c24xx over to dmaengine Mark Brown
2014-06-05 14:04 ` Arnd Bergmann
2014-06-12 13:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539070B1.8070404@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox