From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos: mark machine descriptor functions static
Date: Tue, 10 Jun 2014 15:07:10 +0200 [thread overview]
Message-ID: <539702FE.5030902@samsung.com> (raw)
In-Reply-To: <1401771456-6101-1-git-send-email-olof@lixom.net>
Hi Olof,
On 03.06.2014 06:57, Olof Johansson wrote:
> There's no reason to export these functions, and I have no idea why
> they have over time ended up in the header file. As a result, none of
> the checker tools caught it (i.e. sparse was silent on it).
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>
> I'm guessing with all the churn right now this might not apply, so it
> might need manual application around -rc1.
>
> There's definitely room for more cleanup in common.h.
>
> arch/arm/mach-exynos/common.h | 6 ------
> arch/arm/mach-exynos/exynos.c | 10 +++++-----
> 2 files changed, 5 insertions(+), 11 deletions(-)
>
Similar patch and few other clean-up patches were posted some time ago
on the list as a part of PMU rework series, but somehow got missed. They
can be applied independently from rest of the series which is still
under discussion.
Best regards,
Tomasz
prev parent reply other threads:[~2014-06-10 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 4:57 [PATCH] ARM: exynos: mark machine descriptor functions static Olof Johansson
2014-06-10 13:07 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539702FE.5030902@samsung.com \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).