linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: a.hajda@samsung.com (Andrzej Hajda)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] drm/panel: remove unnecessary dependencies
Date: Fri, 13 Jun 2014 07:54:45 +0200	[thread overview]
Message-ID: <539A9225.90304@samsung.com> (raw)
In-Reply-To: <E1Wv7ZP-0004Wb-3J@rmk-PC.arm.linux.org.uk>

Hi Russel,

Thanks for both fixes. Just one nitpick.

On 06/12/2014 06:09 PM, Russell King wrote:
> DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
> DRM_PANEL && DRM.  This is nonsense for two reasons:
> 
> (a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
> without DRM first being enabled.  Hence the && DRM is useless.

This reason is invalid and do not describe the patch anymore.

Regards
Andrzej

> 
> (b) These two configs are already beneath a menu which depends on
> DRM_PANEL being enabled; these options will not be visible without
> DRM_PANEL already being enabled.
> 
> Let's just remove this unnecessary verbosity.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
>  drivers/gpu/drm/panel/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 4ec874da5668..d83958d39f43 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -5,7 +5,7 @@ config DRM_PANEL
>  	  Panel registration and lookup framework.
>  
>  menu "Display Panels"
> -	depends on DRM_PANEL
> +	depends on DRM && DRM_PANEL
>  
>  config DRM_PANEL_SIMPLE
>  	tristate "support for simple panels"
> @@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE
>  
>  config DRM_PANEL_LD9040
>  	tristate "LD9040 RGB/SPI panel"
> -	depends on DRM && DRM_PANEL
>  	depends on OF
>  	select SPI
>  	select VIDEOMODE_HELPERS
>  
>  config DRM_PANEL_S6E8AA0
>  	tristate "S6E8AA0 DSI video mode panel"
> -	depends on DRM && DRM_PANEL
>  	depends on OF
>  	select DRM_MIPI_DSI
>  	select VIDEOMODE_HELPERS
> 

  reply	other threads:[~2014-06-13  5:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 16:09 [PATCH v2 1/2] drm/panel: remove unnecessary dependencies Russell King
2014-06-13  5:54 ` Andrzej Hajda [this message]
2014-06-13 13:06   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539A9225.90304@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).