* [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver
@ 2014-06-16 17:56 Matt Porter
2014-06-16 19:12 ` Alex Elder
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Matt Porter @ 2014-06-16 17:56 UTC (permalink / raw)
To: linux-arm-kernel
Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies",
MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI
driver which is enabled in this defconfig. This results in the
SDHCI driver not being built and a boot failure. Explictly
enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI
driver is built.
Fixes: 5d01b7684b7e ("mmc: simplify SDHCI Kconfig dependencies")
Signed-off-by: Matt Porter <mporter@linaro.org>
---
arch/arm/configs/bcm_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index 9d13dae..dcfc559 100644
--- a/arch/arm/configs/bcm_defconfig
+++ b/arch/arm/configs/bcm_defconfig
@@ -98,6 +98,7 @@ CONFIG_MMC_UNSAFE_RESUME=y
CONFIG_MMC_BLOCK_MINORS=32
CONFIG_MMC_TEST=y
CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_PLTFM=y
CONFIG_MMC_SDHCI_BCM_KONA=y
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
--
1.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver
2014-06-16 17:56 [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver Matt Porter
@ 2014-06-16 19:12 ` Alex Elder
2014-06-16 21:22 ` Ulf Hansson
2014-06-16 21:55 ` Russell King - ARM Linux
2 siblings, 0 replies; 6+ messages in thread
From: Alex Elder @ 2014-06-16 19:12 UTC (permalink / raw)
To: linux-arm-kernel
On 06/16/2014 12:56 PM, Matt Porter wrote:
> Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies",
> MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI
> driver which is enabled in this defconfig. This results in the
> SDHCI driver not being built and a boot failure. Explictly
> enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI
> driver is built.
>
> Fixes: 5d01b7684b7e ("mmc: simplify SDHCI Kconfig dependencies")
> Signed-off-by: Matt Porter <mporter@linaro.org>
Works for me.
Tested-by: Alex Elder <elder@linaro.org>
> ---
> arch/arm/configs/bcm_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index 9d13dae..dcfc559 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -98,6 +98,7 @@ CONFIG_MMC_UNSAFE_RESUME=y
> CONFIG_MMC_BLOCK_MINORS=32
> CONFIG_MMC_TEST=y
> CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_PLTFM=y
> CONFIG_MMC_SDHCI_BCM_KONA=y
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver
2014-06-16 17:56 [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver Matt Porter
2014-06-16 19:12 ` Alex Elder
@ 2014-06-16 21:22 ` Ulf Hansson
2014-06-16 21:55 ` Russell King - ARM Linux
2 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2014-06-16 21:22 UTC (permalink / raw)
To: linux-arm-kernel
On 16 June 2014 19:56, Matt Porter <mporter@linaro.org> wrote:
> Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies",
> MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI
> driver which is enabled in this defconfig. This results in the
> SDHCI driver not being built and a boot failure. Explictly
> enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI
> driver is built.
>
> Fixes: 5d01b7684b7e ("mmc: simplify SDHCI Kconfig dependencies")
> Signed-off-by: Matt Porter <mporter@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
I suppose this goes through arm-soc, but ping me if want me to send
this as a fix for 3.16.
Kind regards
Uffe
> ---
> arch/arm/configs/bcm_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index 9d13dae..dcfc559 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -98,6 +98,7 @@ CONFIG_MMC_UNSAFE_RESUME=y
> CONFIG_MMC_BLOCK_MINORS=32
> CONFIG_MMC_TEST=y
> CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_PLTFM=y
> CONFIG_MMC_SDHCI_BCM_KONA=y
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver
2014-06-16 17:56 [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver Matt Porter
2014-06-16 19:12 ` Alex Elder
2014-06-16 21:22 ` Ulf Hansson
@ 2014-06-16 21:55 ` Russell King - ARM Linux
2014-06-16 22:16 ` Stephen Warren
2 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2014-06-16 21:55 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 16, 2014 at 01:56:16PM -0400, Matt Porter wrote:
> Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies",
> MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI
> driver which is enabled in this defconfig. This results in the
> SDHCI driver not being built and a boot failure. Explictly
> enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI
> driver is built.
I really don't understand why MMC_SDHCI_PLTFM isn't selected by the
sub-drivers. sdhci-pltfm.c is a library module, which is only
useful with one of the sub-drivers enabled.
So, rather than providing a multitude of dependent options, why not
present people with:
+ sdhci drivers
+ sdhci pci
+ sdhci acpi
+ Arasan
+ Freescale eSDHC
+ Nintendo Wii
+ Dove
and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to
enable building of sdhci-pltfm.c.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver
2014-06-16 21:55 ` Russell King - ARM Linux
@ 2014-06-16 22:16 ` Stephen Warren
2014-06-17 11:46 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2014-06-16 22:16 UTC (permalink / raw)
To: linux-arm-kernel
On 06/16/2014 03:55 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 16, 2014 at 01:56:16PM -0400, Matt Porter wrote:
>> Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies",
>> MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI
>> driver which is enabled in this defconfig. This results in the
>> SDHCI driver not being built and a boot failure. Explictly
>> enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI
>> driver is built.
>
> I really don't understand why MMC_SDHCI_PLTFM isn't selected by the
> sub-drivers. sdhci-pltfm.c is a library module, which is only
> useful with one of the sub-drivers enabled.
>
> So, rather than providing a multitude of dependent options, why not
> present people with:
>
> + sdhci drivers
> + sdhci pci
> + sdhci acpi
> + Arasan
> + Freescale eSDHC
> + Nintendo Wii
> + Dove
>
> and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to
> enable building of sdhci-pltfm.c.
CC'ing Arnd, as author of 5d01b7684b7e "mmc: simplify SDHCI Kconfig
dependencies". I also forgot to do that on the patch that fixed
multi_v7_defconfig for this:-(
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver
2014-06-16 22:16 ` Stephen Warren
@ 2014-06-17 11:46 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2014-06-17 11:46 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 17 June 2014, Stephen Warren wrote:
> On 06/16/2014 03:55 PM, Russell King - ARM Linux wrote:
> > On Mon, Jun 16, 2014 at 01:56:16PM -0400, Matt Porter wrote:
> >> Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies",
> >> MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI
> >> driver which is enabled in this defconfig. This results in the
> >> SDHCI driver not being built and a boot failure. Explictly
> >> enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI
> >> driver is built.
> >
> > I really don't understand why MMC_SDHCI_PLTFM isn't selected by the
> > sub-drivers. sdhci-pltfm.c is a library module, which is only
> > useful with one of the sub-drivers enabled.
> >
> > So, rather than providing a multitude of dependent options, why not
> > present people with:
> >
> > + sdhci drivers
> > + sdhci pci
> > + sdhci acpi
> > + Arasan
> > + Freescale eSDHC
> > + Nintendo Wii
> > + Dove
> >
> > and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to
> > enable building of sdhci-pltfm.c.
>
> CC'ing Arnd, as author of 5d01b7684b7e "mmc: simplify SDHCI Kconfig
> dependencies". I also forgot to do that on the patch that fixed
> multi_v7_defconfig for this:-(
I think doing it the other way round as Russell suggested is a good
idea, and we can definitely do that. We have a similar situation in
other subsystems, sometimes we do it one way and sometimes the other.
The problem I was addressing in my patch was that the SDHCI driver
in particular was mixing the two approaches, which is much worse
as that can cause Kconfig dependency loops and is rather confusing.
I picked the approach that seemed simpler at the time.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-17 11:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 17:56 [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver Matt Porter
2014-06-16 19:12 ` Alex Elder
2014-06-16 21:22 ` Ulf Hansson
2014-06-16 21:55 ` Russell King - ARM Linux
2014-06-16 22:16 ` Stephen Warren
2014-06-17 11:46 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).