From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver
Date: Mon, 16 Jun 2014 16:16:39 -0600 [thread overview]
Message-ID: <539F6CC7.4010002@wwwdotorg.org> (raw)
In-Reply-To: <20140616215512.GC23430@n2100.arm.linux.org.uk>
On 06/16/2014 03:55 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 16, 2014 at 01:56:16PM -0400, Matt Porter wrote:
>> Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies",
>> MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI
>> driver which is enabled in this defconfig. This results in the
>> SDHCI driver not being built and a boot failure. Explictly
>> enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI
>> driver is built.
>
> I really don't understand why MMC_SDHCI_PLTFM isn't selected by the
> sub-drivers. sdhci-pltfm.c is a library module, which is only
> useful with one of the sub-drivers enabled.
>
> So, rather than providing a multitude of dependent options, why not
> present people with:
>
> + sdhci drivers
> + sdhci pci
> + sdhci acpi
> + Arasan
> + Freescale eSDHC
> + Nintendo Wii
> + Dove
>
> and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to
> enable building of sdhci-pltfm.c.
CC'ing Arnd, as author of 5d01b7684b7e "mmc: simplify SDHCI Kconfig
dependencies". I also forgot to do that on the patch that fixed
multi_v7_defconfig for this:-(
next prev parent reply other threads:[~2014-06-16 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 17:56 [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver Matt Porter
2014-06-16 19:12 ` Alex Elder
2014-06-16 21:22 ` Ulf Hansson
2014-06-16 21:55 ` Russell King - ARM Linux
2014-06-16 22:16 ` Stephen Warren [this message]
2014-06-17 11:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F6CC7.4010002@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).