public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x
Date: Thu, 19 Jun 2014 18:24:58 +0200	[thread overview]
Message-ID: <53A30EDA.7050407@free-electrons.com> (raw)
In-Reply-To: <CAL_Jsq+JyngWXvk6ZzV8LPfGqVMDPyouJsADaokAGzgHv=gphQ@mail.gmail.com>

Hi Rob,

On 19/06/2014 16:54, Rob Herring wrote:
> On Thu, Jun 19, 2014 at 9:07 AM, Gregory CLEMENT
> <gregory.clement@free-electrons.com> wrote:
>> For the Armada 380 and Armada 385 SoCs, the common bindings for those
>> 2 SoCs, was forgotten. This patch add the documentation for the
>> marvell,aramda38x property.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>> Hi,
>>
>> This fix should be merged in 3.16. For 3.15 I am not sure as it is not
>> a regression.
>>
>> Thanks,
>> Gregory
>>
>>  Documentation/devicetree/bindings/arm/armada-38x.txt | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/armada-38x.txt b/Documentation/devicetree/bindings/arm/armada-38x.txt
>> index 11f2330a6554..b68bcb80d2de 100644
>> --- a/Documentation/devicetree/bindings/arm/armada-38x.txt
>> +++ b/Documentation/devicetree/bindings/arm/armada-38x.txt
>> @@ -6,5 +6,9 @@ following property:
>>
>>  Required root node property:
>>
>> +compatible: must contain "marvell,armada38x"
>> +
>> +Required root node property:
>> +
>>   - compatible: must contain either "marvell,armada380" or
>>     "marvell,armada385" depending on the variant of the SoC being used.
> 
> This looks a bit strange. How about something like this:
> 
>    - compatible: must contain either "marvell,armada380" or
>      "marvell,armada385" depending on the variant of the SoC being
> used and contain "marvell,armada38x".

Indeed it will be more clear written in this way.


Thanks,

Gregory


> 
> Rob
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2014-06-19 16:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19 14:07 [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x Gregory CLEMENT
2014-06-19 14:54 ` Rob Herring
2014-06-19 16:24   ` Gregory CLEMENT [this message]
2014-06-19 16:32 ` Sergei Shtylyov
2014-06-19 16:34 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A30EDA.7050407@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox