From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v0 1/3] ata: Fix the watermark threshold for the APM X-Gene SATA host controller driver.
Date: Fri, 20 Jun 2014 19:24:16 +0400 [thread overview]
Message-ID: <53A45220.1030406@cogentembedded.com> (raw)
In-Reply-To: <1403253147-14341-2-git-send-email-stripathi@apm.com>
Hello.
On 06/20/2014 12:32 PM, Suman Tripathi wrote:
> This patch fixes the watermark threshold of the receive FIFO for the
> APM X-Gene SATA host controller driver.
> Signed-off-by: Loc Ho <lho@apm.com>
> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> ---
> drivers/ata/ahci_xgene.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> index 77c89bf..5f0f750 100644
> --- a/drivers/ata/ahci_xgene.c
> +++ b/drivers/ata/ahci_xgene.c
> @@ -68,6 +68,10 @@
> #define PORTAXICFG_OUTTRANS_SET(dst, src) \
> (((dst) & ~0x00f00000) | (((u32)(src) << 0x14) & 0x00f00000))
>
> +#define PORTRANSCFG 0xc8
> +#define PORTRANSCFG_RXWM_SET(dst, src) \
> + (((dst) & ~0x0000007f) | (((u32) (src) << 0) & 0x0000007f))
Please renmove space after (u32) for consistency with the above macro. And
why shift by 0 bits?
WBR, Sergei
next parent reply other threads:[~2014-06-20 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1403253147-14341-1-git-send-email-stripathi@apm.com>
[not found] ` <1403253147-14341-2-git-send-email-stripathi@apm.com>
2014-06-20 15:24 ` Sergei Shtylyov [this message]
[not found] ` <1403253147-14341-3-git-send-email-stripathi@apm.com>
2014-06-20 15:25 ` [PATCH v0 2/3] ata: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver Sergei Shtylyov
2014-06-20 15:40 ` Don Dutile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A45220.1030406@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).