linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gaku.inami.xw@bp.renesas.com (Gaku Inami)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: Remove opps table check for cpufreq
Date: Wed, 25 Jun 2014 18:01:32 +0900	[thread overview]
Message-ID: <53AA8FEC.6050808@bp.renesas.com> (raw)
In-Reply-To: <CAKohpo=vEJ0chenDiPQiAMHUTmuRArQPAbG1ym94-9FN32z+DA@mail.gmail.com>

(2014/06/25 17:04), Viresh Kumar wrote:
> On 25 June 2014 13:28, Gaku Inami <gaku.inami.xw@bp.renesas.com> wrote:
>> This patch is based on feedback from Viresh Kumar.
>> Since cpufreq-cpu0 driver has already check opp table, there is no
>> need to same check in mach-shmobile.
>>
>> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
>> ---
>>
>> Based on : renesas-devel-v3.16-rc2-20140623
> I hope you have tested that this doesn't break it :)

I have already tested this patch.
There was no problem to verify the following cases.
  case1 : Normal case
  case2 : Opps table is not exist
  case3 : CONFIG_GENERIC_CPUFREQ_CPU0 is disabled

>>  arch/arm/mach-shmobile/cpufreq.c |   16 +---------------
>>  1 file changed, 1 insertion(+), 15 deletions(-)
>>
>> diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c
>> index e2c868f..8a24b2b 100644
>> --- a/arch/arm/mach-shmobile/cpufreq.c
>> +++ b/arch/arm/mach-shmobile/cpufreq.c
>> @@ -8,24 +8,10 @@
>>   * for more details.
>>   */
>>
>> -#include <linux/of.h>
>> -#include <linux/of_device.h>
>>  #include <linux/platform_device.h>
>>
>>  int __init shmobile_cpufreq_init(void)
>>  {
>> -       struct device_node *np;
>> -
>> -       np = of_cpu_device_node_get(0);
>> -       if (np == NULL) {
>> -               pr_err("failed to find cpu0 node\n");
>> -               return 0;
>> -       }
>> -
>> -       if (of_get_property(np, "operating-points", NULL))
>> -               platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>> -
>> -       of_node_put(np);
>> -
>> +       platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>>         return 0;
>>  }
> Now that there is nothing else in this file, do you really need a separate
> file for cpufreq?
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Thank you for your ack. I hope to leave this file.
In the future, I will add a fix that depends on Renesas-SoC to this file.

  reply	other threads:[~2014-06-25  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25  7:58 [PATCH] ARM: shmobile: Remove opps table check for cpufreq Gaku Inami
2014-06-25  8:04 ` Viresh Kumar
2014-06-25  9:01   ` Gaku Inami [this message]
2014-07-09  8:50     ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2014-07-12 13:53 [GIT PULL] Second Round of Renesas ARM Based SoC CPUFreq Updates for v3.17 Simon Horman
2014-07-12 13:53 ` [PATCH] ARM: shmobile: Remove opps table check for cpufreq Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AA8FEC.6050808@bp.renesas.com \
    --to=gaku.inami.xw@bp.renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).