* [PATCH] ARM: shmobile: Remove opps table check for cpufreq
@ 2014-06-25 7:58 Gaku Inami
2014-06-25 8:04 ` Viresh Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Gaku Inami @ 2014-06-25 7:58 UTC (permalink / raw)
To: linux-arm-kernel
This patch is based on feedback from Viresh Kumar.
Since cpufreq-cpu0 driver has already check opp table, there is no
need to same check in mach-shmobile.
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
---
Based on : renesas-devel-v3.16-rc2-20140623
arch/arm/mach-shmobile/cpufreq.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c
index e2c868f..8a24b2b 100644
--- a/arch/arm/mach-shmobile/cpufreq.c
+++ b/arch/arm/mach-shmobile/cpufreq.c
@@ -8,24 +8,10 @@
* for more details.
*/
-#include <linux/of.h>
-#include <linux/of_device.h>
#include <linux/platform_device.h>
int __init shmobile_cpufreq_init(void)
{
- struct device_node *np;
-
- np = of_cpu_device_node_get(0);
- if (np == NULL) {
- pr_err("failed to find cpu0 node\n");
- return 0;
- }
-
- if (of_get_property(np, "operating-points", NULL))
- platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
-
- of_node_put(np);
-
+ platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: shmobile: Remove opps table check for cpufreq
2014-06-25 7:58 [PATCH] ARM: shmobile: Remove opps table check for cpufreq Gaku Inami
@ 2014-06-25 8:04 ` Viresh Kumar
2014-06-25 9:01 ` Gaku Inami
0 siblings, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2014-06-25 8:04 UTC (permalink / raw)
To: linux-arm-kernel
On 25 June 2014 13:28, Gaku Inami <gaku.inami.xw@bp.renesas.com> wrote:
> This patch is based on feedback from Viresh Kumar.
> Since cpufreq-cpu0 driver has already check opp table, there is no
> need to same check in mach-shmobile.
>
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> ---
>
> Based on : renesas-devel-v3.16-rc2-20140623
I hope you have tested that this doesn't break it :)
> arch/arm/mach-shmobile/cpufreq.c | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c
> index e2c868f..8a24b2b 100644
> --- a/arch/arm/mach-shmobile/cpufreq.c
> +++ b/arch/arm/mach-shmobile/cpufreq.c
> @@ -8,24 +8,10 @@
> * for more details.
> */
>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
>
> int __init shmobile_cpufreq_init(void)
> {
> - struct device_node *np;
> -
> - np = of_cpu_device_node_get(0);
> - if (np == NULL) {
> - pr_err("failed to find cpu0 node\n");
> - return 0;
> - }
> -
> - if (of_get_property(np, "operating-points", NULL))
> - platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
> -
> - of_node_put(np);
> -
> + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
> return 0;
> }
Now that there is nothing else in this file, do you really need a separate
file for cpufreq?
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: shmobile: Remove opps table check for cpufreq
2014-06-25 8:04 ` Viresh Kumar
@ 2014-06-25 9:01 ` Gaku Inami
2014-07-09 8:50 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Gaku Inami @ 2014-06-25 9:01 UTC (permalink / raw)
To: linux-arm-kernel
(2014/06/25 17:04), Viresh Kumar wrote:
> On 25 June 2014 13:28, Gaku Inami <gaku.inami.xw@bp.renesas.com> wrote:
>> This patch is based on feedback from Viresh Kumar.
>> Since cpufreq-cpu0 driver has already check opp table, there is no
>> need to same check in mach-shmobile.
>>
>> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
>> ---
>>
>> Based on : renesas-devel-v3.16-rc2-20140623
> I hope you have tested that this doesn't break it :)
I have already tested this patch.
There was no problem to verify the following cases.
case1 : Normal case
case2 : Opps table is not exist
case3 : CONFIG_GENERIC_CPUFREQ_CPU0 is disabled
>> arch/arm/mach-shmobile/cpufreq.c | 16 +---------------
>> 1 file changed, 1 insertion(+), 15 deletions(-)
>>
>> diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c
>> index e2c868f..8a24b2b 100644
>> --- a/arch/arm/mach-shmobile/cpufreq.c
>> +++ b/arch/arm/mach-shmobile/cpufreq.c
>> @@ -8,24 +8,10 @@
>> * for more details.
>> */
>>
>> -#include <linux/of.h>
>> -#include <linux/of_device.h>
>> #include <linux/platform_device.h>
>>
>> int __init shmobile_cpufreq_init(void)
>> {
>> - struct device_node *np;
>> -
>> - np = of_cpu_device_node_get(0);
>> - if (np == NULL) {
>> - pr_err("failed to find cpu0 node\n");
>> - return 0;
>> - }
>> -
>> - if (of_get_property(np, "operating-points", NULL))
>> - platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>> -
>> - of_node_put(np);
>> -
>> + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
>> return 0;
>> }
> Now that there is nothing else in this file, do you really need a separate
> file for cpufreq?
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Thank you for your ack. I hope to leave this file.
In the future, I will add a fix that depends on Renesas-SoC to this file.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: shmobile: Remove opps table check for cpufreq
2014-06-25 9:01 ` Gaku Inami
@ 2014-07-09 8:50 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2014-07-09 8:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 25, 2014 at 06:01:32PM +0900, Gaku Inami wrote:
> (2014/06/25 17:04), Viresh Kumar wrote:
> > On 25 June 2014 13:28, Gaku Inami <gaku.inami.xw@bp.renesas.com> wrote:
> >> This patch is based on feedback from Viresh Kumar.
> >> Since cpufreq-cpu0 driver has already check opp table, there is no
> >> need to same check in mach-shmobile.
> >>
> >> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> >> ---
> >>
> >> Based on : renesas-devel-v3.16-rc2-20140623
> > I hope you have tested that this doesn't break it :)
>
> I have already tested this patch.
> There was no problem to verify the following cases.
> case1 : Normal case
> case2 : Opps table is not exist
> case3 : CONFIG_GENERIC_CPUFREQ_CPU0 is disabled
Thanks, and sorry for letting this slip through the cracks.
I have queued it up.
> >> arch/arm/mach-shmobile/cpufreq.c | 16 +---------------
> >> 1 file changed, 1 insertion(+), 15 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c
> >> index e2c868f..8a24b2b 100644
> >> --- a/arch/arm/mach-shmobile/cpufreq.c
> >> +++ b/arch/arm/mach-shmobile/cpufreq.c
> >> @@ -8,24 +8,10 @@
> >> * for more details.
> >> */
> >>
> >> -#include <linux/of.h>
> >> -#include <linux/of_device.h>
> >> #include <linux/platform_device.h>
> >>
> >> int __init shmobile_cpufreq_init(void)
> >> {
> >> - struct device_node *np;
> >> -
> >> - np = of_cpu_device_node_get(0);
> >> - if (np == NULL) {
> >> - pr_err("failed to find cpu0 node\n");
> >> - return 0;
> >> - }
> >> -
> >> - if (of_get_property(np, "operating-points", NULL))
> >> - platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
> >> -
> >> - of_node_put(np);
> >> -
> >> + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
> >> return 0;
> >> }
> > Now that there is nothing else in this file, do you really need a separate
> > file for cpufreq?
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Thank you for your ack. I hope to leave this file.
> In the future, I will add a fix that depends on Renesas-SoC to this file.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [GIT PULL] Second Round of Renesas ARM Based SoC CPUFreq Updates for v3.17
@ 2014-07-12 13:53 Simon Horman
2014-07-12 13:53 ` [PATCH] ARM: shmobile: Remove opps table check for cpufreq Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2014-07-12 13:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Olof, Hi Kevin, Hi Arnd,
Please consider these second round of Renesas ARM based SoC CPUFreq
updates for v3.17.
This pull request is based on the previous round of
such requests, tagged as renesas-cpufreq-for-v3.17,
which I have already sent a pull-request for.
The following changes since commit 06e32c91dbce3c24ccbe84e3af2a35199662bca0:
ARM: shmobile: add cpufreq-cpu0 driver for common SH-Mobile (2014-06-16 19:50:54 +0900)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git renesas-cpufreq2-for-v3.17
for you to fetch changes up to e423d12cbcb9576785e891617888f627f1f57bf4:
ARM: shmobile: Remove opps table check for cpufreq (2014-07-09 10:48:58 +0200)
----------------------------------------------------------------
Second Round of Renesas ARM Based SoC CPUFreq Updates for v3.17
* Remove opps table check for cpufreq as this is already handled
by the driver
----------------------------------------------------------------
Gaku Inami (1):
ARM: shmobile: Remove opps table check for cpufreq
arch/arm/mach-shmobile/cpufreq.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: shmobile: Remove opps table check for cpufreq
2014-07-12 13:53 [GIT PULL] Second Round of Renesas ARM Based SoC CPUFreq Updates for v3.17 Simon Horman
@ 2014-07-12 13:53 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2014-07-12 13:53 UTC (permalink / raw)
To: linux-arm-kernel
From: Gaku Inami <gaku.inami.xw@bp.renesas.com>
This patch is based on feedback from Viresh Kumar.
Since cpufreq-cpu0 driver has already check opp table, there is no
need to same check in mach-shmobile.
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/cpufreq.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c
index e2c868f..8a24b2b 100644
--- a/arch/arm/mach-shmobile/cpufreq.c
+++ b/arch/arm/mach-shmobile/cpufreq.c
@@ -8,24 +8,10 @@
* for more details.
*/
-#include <linux/of.h>
-#include <linux/of_device.h>
#include <linux/platform_device.h>
int __init shmobile_cpufreq_init(void)
{
- struct device_node *np;
-
- np = of_cpu_device_node_get(0);
- if (np == NULL) {
- pr_err("failed to find cpu0 node\n");
- return 0;
- }
-
- if (of_get_property(np, "operating-points", NULL))
- platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
-
- of_node_put(np);
-
+ platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
return 0;
}
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-12 13:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-25 7:58 [PATCH] ARM: shmobile: Remove opps table check for cpufreq Gaku Inami
2014-06-25 8:04 ` Viresh Kumar
2014-06-25 9:01 ` Gaku Inami
2014-07-09 8:50 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2014-07-12 13:53 [GIT PULL] Second Round of Renesas ARM Based SoC CPUFreq Updates for v3.17 Simon Horman
2014-07-12 13:53 ` [PATCH] ARM: shmobile: Remove opps table check for cpufreq Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).