From: denis@eukrea.com (Denis Carikli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] video: imxfb: Fix lcd_ops .set_power and .get_power on/off inversion
Date: Wed, 25 Jun 2014 14:57:11 +0200 [thread overview]
Message-ID: <53AAC727.60702@eukrea.com> (raw)
In-Reply-To: <20140625061611.GF15686@pengutronix.de>
On 06/25/2014 08:16 AM, Sascha Hauer wrote:
> You use IS_ERR_OR_NULL() here. imxfb_lcd_set_power uses IS_ERR(). One of
> both must be wrong.
Fixed by using IS_ERR_OR_NULL.
> You could reduce indentation by bailing out early:
>
> if (IS_ERR(fbi->lcd_pwr))
> return 0;
Fixed (with IS_ERR_OR_NULL).
Denis.
next prev parent reply other threads:[~2014-06-25 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 13:07 [PATCH v2 1/2] video: imxfb: Fix unbalanced regulators Denis Carikli
2014-06-23 13:07 ` [PATCH v2 2/2] video: imxfb: Fix lcd_ops .set_power and .get_power on/off inversion Denis Carikli
2014-06-25 6:16 ` Sascha Hauer
2014-06-25 12:57 ` Denis Carikli [this message]
2014-06-25 6:08 ` [PATCH v2 1/2] video: imxfb: Fix unbalanced regulators Sascha Hauer
2014-06-25 8:51 ` Denis Carikli
2014-06-25 8:58 ` Denis Carikli
2014-06-25 9:33 ` Sascha Hauer
2014-06-25 6:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAC727.60702@eukrea.com \
--to=denis@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).