From: denis@eukrea.com (Denis Carikli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] ARM: i.MX25 clk: Use of_clk_init() for DT case
Date: Wed, 25 Jun 2014 16:21:51 +0200 [thread overview]
Message-ID: <53AADAFF.2000800@eukrea.com> (raw)
In-Reply-To: <CAOMZO5CSARSPA2K94pQc6osC+8-4jPZsYvV2bQybCXCASmohSg@mail.gmail.com>
On 06/25/2014 04:13 PM, Fabio Estevam wrote:
>
> On Wed, Jun 25, 2014 at 9:41 AM, Denis Carikli <denis@eukrea.com> wrote:
>
>> int __init mx25_clocks_init(void)
>> {
>> - __mx25_clocks_init(24000000);
>> + void __iomem *ccm;
>> +
>> + ccm = ioremap(MX25_CRM_BASE_ADDR, SZ_16K);
>
> Shouldn't the ccm base address be retrieved from dt?
Yes, it is.
As I understand it mx25_clocks_init is called only by the boards files
(mach-eukrea_cpuimx25.c and mach-mx25_3ds.c) while mx25_clocks_init_dt
is what is used in the case of a DT boot (in imx25-dt.c).
Denis.
next prev parent reply other threads:[~2014-06-25 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 12:41 [PATCH v3 1/3] ARM i.MX25 clk: Fix gpt timer clock Denis Carikli
2014-06-25 12:41 ` [PATCH v3 2/3] ARM: dts: i.MX25: Fix gpt timers clocks Denis Carikli
2014-06-25 17:55 ` Fabio Estevam
2014-06-25 12:41 ` [PATCH v3 3/3] ARM: i.MX25 clk: Use of_clk_init() for DT case Denis Carikli
2014-06-25 14:13 ` Fabio Estevam
2014-06-25 14:21 ` Denis Carikli [this message]
2014-06-26 5:43 ` Sascha Hauer
2014-06-28 15:11 ` [PATCH v3 1/3] ARM i.MX25 clk: Fix gpt timer clock Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AADAFF.2000800@eukrea.com \
--to=denis@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).