From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Thu, 26 Jun 2014 16:34:59 +0400 Subject: [PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes In-Reply-To: <53AB9581.7090806@renesas.com> References: <201406242157.05973.sergei.shtylyov@cogentembedded.com> <201406242159.55373.sergei.shtylyov@cogentembedded.com> <53AB89B3.9020207@renesas.com> <53AB9581.7090806@renesas.com> Message-ID: <53AC1373.5010501@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 06/26/2014 07:37 AM, Yoshihiro Shimoda wrote: >>>> From: Ben Dooks >>>> Add device nodes for the R8A7790 internal PCI bridge devices. >>>> Signed-off-by: Ben Dooks >>>> Reviewed-by: Ian Molton >>>> [Sergei: added several properties to the PCI bridge nodes] >>>> Signed-off-by: Sergei Shtylyov >>> Thank you for the patch! >>> I tested this patch on my lager board and a usb memory, and it works. >>> Tested-by: Yoshihiro Shimoda >> Thanks for testing. Just one quick question from my side: Which USB >> port did you test? > I tested usb ch1 only... Note that channel #2 also should work. >> I somehow assumed that at least the majority of the USB ports on R-Car >> Gen2 require a USB PHY device driver to work? > > Thank you for the point. > About usb ch1, a USB PHY device driver doesn't need, I think. > But, about ch0 and ch2, I think that they should require a USB PHY device driver. Only channel #0 requires the PHY driver as the default routing for USB0 is to USBHS; channel #2 is routed to OHCI/EHCI by default. > Best regards, > Yoshihiro Shimoda WBR, Sergei