From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: tegra: export clock names for debugging
Date: Thu, 26 Jun 2014 22:32:23 +0400 [thread overview]
Message-ID: <53AC6737.5010507@cogentembedded.com> (raw)
In-Reply-To: <1403797705-26910-1-git-send-email-pdeschrijver@nvidia.com>
Hello.
On 06/26/2014 07:48 PM, Peter De Schrijver wrote:
> When writing a module for testing or debugging purposes, there is no way to
> get hold of clk handles. This patch solves this by exposing all valid clocks
> as clkdev's for the virtual device tegra-clk-debug.
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---
> drivers/clk/tegra/clk.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
> index c0a7d77..3315fca 100644
> --- a/drivers/clk/tegra/clk.c
> +++ b/drivers/clk/tegra/clk.c
> @@ -277,6 +277,12 @@ void __init tegra_register_devclks(struct tegra_devclk *dev_clks, int num)
> for (i = 0; i < num; i++, dev_clks++)
> clk_register_clkdev(clks[dev_clks->dt_id], dev_clks->con_id,
> dev_clks->dev_id);
> +
> + for (i = 0; i < clk_num; i++) {
> + if (!IS_ERR(clks[i]) || !clks[i])
Are you sure it should be || here, not &&? The following code doesn't seem
to make much sense this way... Perhaps you meant !IS_ERR_OR_NULL(clks[i])?
> + clk_register_clkdev(clks[i], __clk_get_name(clks[i]),
> + "tegra-clk-debug");
> + }
> }
WBR, Sergei
prev parent reply other threads:[~2014-06-26 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 15:48 [PATCH] clk: tegra: export clock names for debugging Peter De Schrijver
2014-06-26 15:52 ` Stephen Warren
2014-06-27 12:19 ` Peter De Schrijver
2014-06-27 15:59 ` Stephen Warren
2014-06-26 18:32 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC6737.5010507@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).