linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/7] irqchip: atmel-aic: add new atmel AIC driver
Date: Thu, 26 Jun 2014 22:20:24 +0200	[thread overview]
Message-ID: <53AC8088.6020905@free-electrons.com> (raw)
In-Reply-To: <1403276487-8792-4-git-send-email-boris.brezillon@free-electrons.com>


On 20/06/2014 17:01, Boris BREZILLON wrote:
> Add new atmel AIC (Advanced Interrupt Controller) driver based on the
> generic chip infrastructure.
>
> This driver is only compatible with dt enabled board and replaces the old
> implementation found in arch/arm/mach-at91/irq.c.
>
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> ---
>  drivers/irqchip/Kconfig         |   7 +
>  drivers/irqchip/Makefile        |   1 +
>  drivers/irqchip/irq-atmel-aic.c | 700 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 708 insertions(+)
>  create mode 100644 drivers/irqchip/irq-atmel-aic.c
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index bbb746e..6a7ad81 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -30,6 +30,13 @@ config ARM_VIC_NR
>  	  The maximum number of VICs available in the system, for
>  	  power management.
>  
> +config ATMEL_AIC_IRQ
> +	bool
> +	select GENERIC_IRQ_CHIP
> +	select IRQ_DOMAIN
> +	select MULTI_IRQ_HANDLER
> +	select SPARSE_IRQ
> +

I just though a bit about it and it might be better to split AIC and
AIC5 support in 2 different drivers, because the AIC is only available
on at91sam9/at91rm9200 SoCs and AIC5 only available on sama5 SoCs, and
AFAICT there is no combination of both controller in a singler SoC.

Jason, Thomas, let me know if you think this worth the trouble, and if
so, should I keep a common implementation (in irq-atmel-aic-common.c/.h)
for the shared functions/structures.

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2014-06-26 20:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 15:01 [PATCH v3 0/7] ARM: at91: move aic driver to drivers/irqchips Boris BREZILLON
2014-06-20 15:01 ` [PATCH v3 1/7] genirq: generic chip: export irq_map_generic_chip function Boris BREZILLON
2014-06-21 23:51   ` Jason Cooper
2014-06-22  7:59     ` Boris BREZILLON
2014-06-23 13:07       ` Jason Cooper
2014-06-23 15:07         ` Boris BREZILLON
2014-06-23 17:50           ` Jason Cooper
2014-06-23 20:10             ` Boris BREZILLON
2014-06-23 22:14               ` Jason Cooper
2014-06-23 22:17   ` Jason Cooper
2014-06-23 22:40     ` Thomas Gleixner
2014-06-20 15:01 ` [PATCH v3 2/7] irqchip: atmel-aic: move binding doc to interrupt-controller directory Boris BREZILLON
2014-06-20 15:01 ` [PATCH v3 3/7] irqchip: atmel-aic: add new atmel AIC driver Boris BREZILLON
2014-06-22 20:56   ` Boris BREZILLON
2014-06-24 12:56     ` Jason Cooper
2014-06-24 16:14       ` Boris BREZILLON
2014-06-24 20:00         ` Jason Cooper
2014-06-26 20:20   ` Boris BREZILLON [this message]
2014-06-26 20:30     ` Jason Cooper
2014-07-09 16:38       ` Nicolas Ferre
2014-06-20 15:01 ` [PATCH v3 4/7] ARM: at91: introduce OLD_IRQ_AT91 Kconfig option Boris BREZILLON
2014-06-20 15:01 ` [PATCH v3 5/7] ARM: at91: enclose at91_aic_xx calls in IS_ENABLED(CONFIG_OLD_IRQ_AT91) blocks Boris BREZILLON
2014-06-20 15:01 ` [PATCH v3 6/7] ARM: at91: make use of the new AIC driver for dt enabled boards Boris BREZILLON
2014-06-20 15:01 ` [PATCH v3 7/7] ARM: at91: remove old irq material Boris BREZILLON
2014-07-09 16:44 ` [PATCH v3 0/7] ARM: at91: move aic driver to drivers/irqchips Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AC8088.6020905@free-electrons.com \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).