From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: dra7xx-clocks: Fix the l3 and l4 clock rates
Date: Thu, 3 Jul 2014 11:59:11 +0300 [thread overview]
Message-ID: <53B51B5F.5040105@ti.com> (raw)
In-Reply-To: <53B5157A.3020108@ti.com>
On 07/03/2014 11:34 AM, Rajendra Nayak wrote:
> On Tuesday 27 May 2014 02:25 PM, Rajendra Nayak wrote:
>> Without the patch:
>> /debug/.../dpll_core_x2_ck/dpll_core_h12x2_ck # cat clk_rate
>> 532000000
>> /debug/.../dpll_core_x2_ck/dpll_core_h12x2_ck/l3_iclk_div # cat clk_rate
>> 532000000
>> /debug/.../dpll_core_x2_ck/dpll_core_h12x2_ck/l3_iclk_div/l4_root_clk_div # cat clk_rate
>> 532000000
>>
>> With the patch:
>> /debug/.../dpll_core_x2_ck/dpll_core_h12x2_ck # cat clk_rate
>> 532000000
>> /debug/.../dpll_core_x2_ck/dpll_core_h12x2_ck/l3_iclk_div # cat clk_rate
>> 266000000
>> /debug/.../dpll_core_x2_ck/dpll_core_h12x2_ck/l3_iclk_div/l4_root_clk_div # cat clk_rate
>> 133000000
>>
>> The l3 clock derived from core DPLL is actually a divider clock,
>> with the default divider set to 2. l4 then derived from l3 is a fixed factor
>> clock, but the fixed divider is 2 and not 1. Which means the l3 clock is
>> half of core DPLLs h12x2 and l4 is half of l3 (as seen with this patch)
>
> Tero, this seems like is yet to be picked up. You see any issues with this that needs to be
> addressed?
Yea this actually looks good to me. Queued for 3.16-rc dt-clk fixes.
-Tero
>
> regards,
> Rajendra
>
>>
>> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
>> ---
>> arch/arm/boot/dts/dra7xx-clocks.dtsi | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
>> index cfb8fc7..a14c99b 100644
>> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
>> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
>> @@ -673,10 +673,12 @@
>>
>> l3_iclk_div: l3_iclk_div {
>> #clock-cells = <0>;
>> - compatible = "fixed-factor-clock";
>> + compatible = "ti,divider-clock";
>> + ti,max-div = <2>;
>> + ti,bit-shift = <4>;
>> + reg = <0x0100>;
>> clocks = <&dpll_core_h12x2_ck>;
>> - clock-mult = <1>;
>> - clock-div = <1>;
>> + ti,index-power-of-two;
>> };
>>
>> l4_root_clk_div: l4_root_clk_div {
>> @@ -684,7 +686,7 @@
>> compatible = "fixed-factor-clock";
>> clocks = <&l3_iclk_div>;
>> clock-mult = <1>;
>> - clock-div = <1>;
>> + clock-div = <2>;
>> };
>>
>> video1_clk2_div: video1_clk2_div {
>>
>
prev parent reply other threads:[~2014-07-03 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 8:55 [PATCH] arm: dts: dra7xx-clocks: Fix the l3 and l4 clock rates Rajendra Nayak
2014-07-03 8:34 ` Rajendra Nayak
2014-07-03 8:59 ` Tero Kristo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B51B5F.5040105@ti.com \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).