* [PATCH] ARM: dts: Add I2S dt node for Exynos3250 @ 2014-07-03 7:52 Chanwoo Choi 2014-07-04 7:43 ` Kukjin Kim 2014-07-04 8:05 ` Tomasz Figa 0 siblings, 2 replies; 6+ messages in thread From: Chanwoo Choi @ 2014-07-03 7:52 UTC (permalink / raw) To: linux-arm-kernel From: Tomasz Figa <t.figa@samsung.com> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo (1 channels) IIS-bus for audio interface with DMA-based operation. Signed-off-by: Tomasz Figa <t.figa@samsung.com> Signed-off-by: Inha Song <ideal.song@samsung.com> Tested-by: Inha Song <ideal.song@samsung.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 1f8384f..e9017ef 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -644,6 +644,19 @@ status = "disabled"; }; + i2s: i2s at 13970000 { + compatible = "samsung,s3c6410-i2s"; + reg = <0x13970000 0x100>; + interrupts = <0 126 0>; + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; + clock-names = "iis", "i2s_opclk0"; + dmas = <&pdma0 14>, <&pdma0 13>; + dma-names = "tx", "rx"; + pinctrl-0 = <&i2s2_bus>; + pinctrl-name = "default"; + status = "disabled"; + }; + pwm: pwm at 139D0000 { compatible = "samsung,exynos4210-pwm"; reg = <0x139D0000 0x1000>; -- 1.8.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Add I2S dt node for Exynos3250 2014-07-03 7:52 [PATCH] ARM: dts: Add I2S dt node for Exynos3250 Chanwoo Choi @ 2014-07-04 7:43 ` Kukjin Kim 2014-07-04 8:00 ` Chanwoo Choi 2014-07-04 8:05 ` Tomasz Figa 1 sibling, 1 reply; 6+ messages in thread From: Kukjin Kim @ 2014-07-04 7:43 UTC (permalink / raw) To: linux-arm-kernel Chanwoo Choi wrote: > > From: Tomasz Figa <t.figa@samsung.com> > > This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo > (1 channels) IIS-bus for audio interface with DMA-based operation. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Inha Song <ideal.song@samsung.com> > Tested-by: Inha Song <ideal.song@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 1f8384f..e9017ef 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -644,6 +644,19 @@ > status = "disabled"; > }; > > + i2s: i2s at 13970000 { > + compatible = "samsung,s3c6410-i2s"; > + reg = <0x13970000 0x100>; > + interrupts = <0 126 0>; > + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0"; > + dmas = <&pdma0 14>, <&pdma0 13>; > + dma-names = "tx", "rx"; > + pinctrl-0 = <&i2s2_bus>; > + pinctrl-name = "default"; To put 'pinctrl-name' and then 'pinctrl-0' is better? :-) > + status = "disabled"; > + }; > + > pwm: pwm at 139D0000 { > compatible = "samsung,exynos4210-pwm"; > reg = <0x139D0000 0x1000>; > -- > 1.8.0 Will apply. Thanks, Kukjin ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Add I2S dt node for Exynos3250 2014-07-04 7:43 ` Kukjin Kim @ 2014-07-04 8:00 ` Chanwoo Choi 0 siblings, 0 replies; 6+ messages in thread From: Chanwoo Choi @ 2014-07-04 8:00 UTC (permalink / raw) To: linux-arm-kernel On 07/04/2014 04:43 PM, Kukjin Kim wrote: > Chanwoo Choi wrote: >> >> From: Tomasz Figa <t.figa@samsung.com> >> >> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo >> (1 channels) IIS-bus for audio interface with DMA-based operation. >> >> Signed-off-by: Tomasz Figa <t.figa@samsung.com> >> Signed-off-by: Inha Song <ideal.song@samsung.com> >> Tested-by: Inha Song <ideal.song@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 1f8384f..e9017ef 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -644,6 +644,19 @@ >> status = "disabled"; >> }; >> >> + i2s: i2s at 13970000 { >> + compatible = "samsung,s3c6410-i2s"; >> + reg = <0x13970000 0x100>; >> + interrupts = <0 126 0>; >> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; >> + clock-names = "iis", "i2s_opclk0"; >> + dmas = <&pdma0 14>, <&pdma0 13>; >> + dma-names = "tx", "rx"; >> + pinctrl-0 = <&i2s2_bus>; >> + pinctrl-name = "default"; > > To put 'pinctrl-name' and then 'pinctrl-0' is better? :-) The i2s dt node can drop "pinctrl-0/pinctrl-name" properties. I will re-send this patchset (v2) after fixing it. Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Add I2S dt node for Exynos3250 2014-07-03 7:52 [PATCH] ARM: dts: Add I2S dt node for Exynos3250 Chanwoo Choi 2014-07-04 7:43 ` Kukjin Kim @ 2014-07-04 8:05 ` Tomasz Figa 2014-07-04 9:18 ` Chanwoo Choi 1 sibling, 1 reply; 6+ messages in thread From: Tomasz Figa @ 2014-07-04 8:05 UTC (permalink / raw) To: linux-arm-kernel Hi Chanwoo, On 03.07.2014 09:52, Chanwoo Choi wrote: > From: Tomasz Figa <t.figa@samsung.com> > > This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo > (1 channels) IIS-bus for audio interface with DMA-based operation. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Inha Song <ideal.song@samsung.com> > Tested-by: Inha Song <ideal.song@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 1f8384f..e9017ef 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -644,6 +644,19 @@ > status = "disabled"; > }; > > + i2s: i2s at 13970000 { Shouldn't the label be rather called "i2s2" as the pinctrl entry below suggests? > + compatible = "samsung,s3c6410-i2s"; > + reg = <0x13970000 0x100>; > + interrupts = <0 126 0>; > + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0"; > + dmas = <&pdma0 14>, <&pdma0 13>; > + dma-names = "tx", "rx"; > + pinctrl-0 = <&i2s2_bus>; > + pinctrl-name = "default"; "pinctrl-name" is not a valid property. I suppose it should be "pinctrl-names". Best regards, Tomasz ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Add I2S dt node for Exynos3250 2014-07-04 8:05 ` Tomasz Figa @ 2014-07-04 9:18 ` Chanwoo Choi 2014-07-08 14:06 ` Tomasz Figa 0 siblings, 1 reply; 6+ messages in thread From: Chanwoo Choi @ 2014-07-04 9:18 UTC (permalink / raw) To: linux-arm-kernel Dear Kukjin and Tomasz, On 07/04/2014 05:05 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 03.07.2014 09:52, Chanwoo Choi wrote: >> From: Tomasz Figa <t.figa@samsung.com> >> >> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo >> (1 channels) IIS-bus for audio interface with DMA-based operation. >> >> Signed-off-by: Tomasz Figa <t.figa@samsung.com> >> Signed-off-by: Inha Song <ideal.song@samsung.com> >> Tested-by: Inha Song <ideal.song@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 1f8384f..e9017ef 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -644,6 +644,19 @@ >> status = "disabled"; >> }; >> >> + i2s: i2s at 13970000 { > > Shouldn't the label be rather called "i2s2" as the pinctrl entry below > suggests? > >> + compatible = "samsung,s3c6410-i2s"; >> + reg = <0x13970000 0x100>; >> + interrupts = <0 126 0>; >> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; >> + clock-names = "iis", "i2s_opclk0"; >> + dmas = <&pdma0 14>, <&pdma0 13>; >> + dma-names = "tx", "rx"; >> + pinctrl-0 = <&i2s2_bus>; >> + pinctrl-name = "default"; > > "pinctrl-name" is not a valid property. I suppose it should be > "pinctrl-names". I modify this patch as following. If you confirm following patch, I'll re-send patchset(v2). diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 3e678fa..77a06df 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -425,6 +425,19 @@ status = "disabled"; }; + i2s2: i2s at 13970000 { + compatible = "samsung,s3c6410-i2s"; + reg = <0x13970000 0x100>; + interrupts = <0 126 0>; + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; + clock-names = "iis", "i2s_opclk0"; + dmas = <&pdma0 14>, <&pdma0 13>; + dma-names = "tx", "rx"; + pinctrl-0 = <&i2s2_bus>; + pinctrl-names = "default"; + status = "disabled"; + }; + pwm: pwm at 139D0000 { compatible = "samsung,exynos4210-pwm"; reg = <0x139D0000 0x1000>; -- 1.8.0 Best Regards, Chanwoo Choi ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Add I2S dt node for Exynos3250 2014-07-04 9:18 ` Chanwoo Choi @ 2014-07-08 14:06 ` Tomasz Figa 0 siblings, 0 replies; 6+ messages in thread From: Tomasz Figa @ 2014-07-08 14:06 UTC (permalink / raw) To: linux-arm-kernel Hi Chanwoo, On 04.07.2014 11:18, Chanwoo Choi wrote: > Dear Kukjin and Tomasz, > > On 07/04/2014 05:05 PM, Tomasz Figa wrote: >> Hi Chanwoo, >> >> On 03.07.2014 09:52, Chanwoo Choi wrote: >>> From: Tomasz Figa <t.figa@samsung.com> >>> >>> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo >>> (1 channels) IIS-bus for audio interface with DMA-based operation. >>> >>> Signed-off-by: Tomasz Figa <t.figa@samsung.com> >>> Signed-off-by: Inha Song <ideal.song@samsung.com> >>> Tested-by: Inha Song <ideal.song@samsung.com> >>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >>> --- >>> arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>> index 1f8384f..e9017ef 100644 >>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>> @@ -644,6 +644,19 @@ >>> status = "disabled"; >>> }; >>> >>> + i2s: i2s at 13970000 { >> >> Shouldn't the label be rather called "i2s2" as the pinctrl entry below >> suggests? >> >>> + compatible = "samsung,s3c6410-i2s"; >>> + reg = <0x13970000 0x100>; >>> + interrupts = <0 126 0>; >>> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; >>> + clock-names = "iis", "i2s_opclk0"; >>> + dmas = <&pdma0 14>, <&pdma0 13>; >>> + dma-names = "tx", "rx"; >>> + pinctrl-0 = <&i2s2_bus>; >>> + pinctrl-name = "default"; >> >> "pinctrl-name" is not a valid property. I suppose it should be >> "pinctrl-names". > > I modify this patch as following. If you confirm following patch, I'll re-send patchset(v2). > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 3e678fa..77a06df 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -425,6 +425,19 @@ > status = "disabled"; > }; > > + i2s2: i2s at 13970000 { > + compatible = "samsung,s3c6410-i2s"; > + reg = <0x13970000 0x100>; > + interrupts = <0 126 0>; > + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0"; > + dmas = <&pdma0 14>, <&pdma0 13>; > + dma-names = "tx", "rx"; > + pinctrl-0 = <&i2s2_bus>; > + pinctrl-names = "default"; > + status = "disabled"; > + }; > + > pwm: pwm at 139D0000 { > compatible = "samsung,exynos4210-pwm"; > reg = <0x139D0000 0x1000>; > Looks good. Best regards, Tomasz ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-08 14:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-03 7:52 [PATCH] ARM: dts: Add I2S dt node for Exynos3250 Chanwoo Choi 2014-07-04 7:43 ` Kukjin Kim 2014-07-04 8:00 ` Chanwoo Choi 2014-07-04 8:05 ` Tomasz Figa 2014-07-04 9:18 ` Chanwoo Choi 2014-07-08 14:06 ` Tomasz Figa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).