From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2
Date: Fri, 04 Jul 2014 13:04:18 +0200 [thread overview]
Message-ID: <53B68A32.8000203@samsung.com> (raw)
In-Reply-To: <20140522185334.GT12304@sirena.org.uk>
On 22/05/14 20:53, Mark Brown wrote:
>> + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S
>> > + | SND_SOC_DAIFMT_NB_NF
>> > + | SND_SOC_DAIFMT_CBM_CFM);
>> > + if (ret < 0)
>> > + return ret;
>> > +
>> > + ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S
>> > + | SND_SOC_DAIFMT_NB_NF
>> > + | SND_SOC_DAIFMT_CBM_CFM);
>> > + if (ret < 0)
>> > + return ret;
>
> These are constant, set these in the dai_link.
set_fmt also sets master/slave mode of the I2S DAI, after I moved
this into the cpu_dai link data structure after suspend/resume cycle
the I2S IP block is not being properly re-configured. Should the
format setting be added in resume_post callback, or is there any
other preferred way ? Similarly the syclk settings are being lost
over suspend/resume cycle and nothing restores them.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2014-07-04 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 11:55 [PATCH 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings Sylwester Nawrocki
2014-05-22 11:55 ` [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2 Sylwester Nawrocki
2014-05-22 18:53 ` Mark Brown
2014-05-23 8:44 ` Sylwester Nawrocki
2014-05-23 11:05 ` Mark Brown
2014-07-04 11:04 ` Sylwester Nawrocki [this message]
2014-07-04 11:10 ` [alsa-devel] " Lars-Peter Clausen
2014-07-04 11:24 ` Sylwester Nawrocki
2014-07-04 11:28 ` Lars-Peter Clausen
2014-05-22 18:46 ` [PATCH 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings Mark Brown
2014-05-23 9:54 ` Sylwester Nawrocki
[not found] <0E.BA.03708.FFFAE735@epcpsbgx1.samsung.com>
2014-05-23 11:11 ` [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B68A32.8000203@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox