[PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2

Sylwester Nawrocki
2014-07-04T11:04:18Z

On 22/05/14 20:53, Mark Brown wrote:
>> + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S
>> > + | SND_SOC_DAIFMT_NB_NF
>> > + | SND_SOC_DAIFMT_CBM_CFM);
>> > + if (ret < 0)
>> > + return ret;
>> > +
>> > + ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S
>> > + | SND_SOC_DAIFMT_NB_NF
>> > + | SND_SOC_DAIFMT_CBM_CFM);
>> > + if (ret < 0)
>> > + return ret;
>
> These are constant, set these in the dai_link.

set_fmt also sets master/slave mode of the I2S DAI, after I moved
this into the cpu_dai link data structure after suspend/resume cycle
the I2S IP block is not being properly re-configured. Should the
format setting be added in resume_post callback, or is there any
other preferred way ? Similarly the syclk settings are being lost
over suspend/resume cycle and nothing restores them.

--
Thanks,
Sylwester