From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework
Date: Fri, 11 Jul 2014 11:51:27 +0200 [thread overview]
Message-ID: <53BFB39F.6040606@samsung.com> (raw)
In-Reply-To: <1405071475-31946-1-git-send-email-tushar.b@samsung.com>
Hi Tushar,
On 11.07.2014 11:37, Tushar Behera wrote:
> The patchset is targetted as moving exising exynos-audss clock driver from being
> a module driver. The driver is now registered through CLK_OF_DECLARE and is
> inline with other Samsung clock drivers.
I'm afraid I have to NAK this series or at least the part converting the
driver back to use CLK_OF_DECLARE().
We have deliberately made this driver a platform driver, because this is
how drivers should be modeled in Linux kernel whenever possible.
CLK_OF_DECLARE() should be only considered a hack to work around late
initialization of driver model. Reverting this change without a good
reason (and you haven't provided such) is just going backwards.
Rest of this series is actually quite nice, though, as reusing Samsung
clock helpers reduces the line count significantly, so if you could
rework this to keep this driver a platform driver then we could get
something I could ack.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-11 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 9:37 [PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework Tushar Behera
2014-07-11 9:37 ` [PATCH 1/2] clk: exynos-audss: Simplify code to get clock names Tushar Behera
2014-07-11 9:37 ` [PATCH 2/2] clk: exynos-audss: Update as per existing framework Tushar Behera
2014-07-11 10:40 ` Sylwester Nawrocki
2014-07-11 12:07 ` Tushar Behera
2014-07-11 9:51 ` Tomasz Figa [this message]
2014-07-11 10:09 ` [PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFB39F.6040606@samsung.com \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).