From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: exynos-audss: Update as per existing framework
Date: Fri, 11 Jul 2014 12:40:24 +0200 [thread overview]
Message-ID: <53BFBF18.3080704@samsung.com> (raw)
In-Reply-To: <1405071475-31946-3-git-send-email-tushar.b@samsung.com>
Hi Tushar,
On 11/07/14 11:37, Tushar Behera wrote:
> Change exynos-audss clock driver as per existing clock framework from
> the existing module driver framework.
Can you explain what's the actual issue you're trying to solve with that
patch ? What's the problem with this driver being a platform driver ?
It feels we're moving in circles here, see
commit b37a4224104568198b93fb9831224cfe7d83fff8
Author: Andrew Bresticker <abrestic@chromium.org>
Date: Wed Sep 25 14:12:47 2013 -0700
clk: exynos-audss: convert to platform device
The Exynos AudioSS clock controller will later be modified to allow
input clocks to be specified via device-tree in order to support
multiple Exynos SoCs. This will introduce a dependency on the core
SoC clock controller being initialized first so that the AudioSS driver
can look up its input clocks, but the order in which clock providers
are probed in of_clk_init() is not guaranteed. Since deferred probing
is not supported in of_clk_init() and the AudioSS block is not the core
controller, we can initialize it later as a platform device.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Acked-by: Tomasz Figa <t.figa@samsung.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Mike Turquette <mturquette@linaro.org>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
I realize of_clk_init() now handles better clock provider dependencies,
nevertheless do we really need all this churn ?
--
Thanks,
Sylwester
next prev parent reply other threads:[~2014-07-11 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 9:37 [PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework Tushar Behera
2014-07-11 9:37 ` [PATCH 1/2] clk: exynos-audss: Simplify code to get clock names Tushar Behera
2014-07-11 9:37 ` [PATCH 2/2] clk: exynos-audss: Update as per existing framework Tushar Behera
2014-07-11 10:40 ` Sylwester Nawrocki [this message]
2014-07-11 12:07 ` Tushar Behera
2014-07-11 9:51 ` [PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework Tomasz Figa
2014-07-11 10:09 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFBF18.3080704@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).