linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rdunlap@infradead.org (Randy Dunlap)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks
Date: Mon, 14 Jul 2014 11:23:26 -0700	[thread overview]
Message-ID: <53C4201E.3020708@infradead.org> (raw)
In-Reply-To: <1405361664-5210-1-git-send-email-xerofoify@gmail.com>

On 07/14/14 11:14, Nicholas Krause wrote:
> This patch addresses the fix me message in this file that states to
> remove all definitions not related to reg-clocks in this header
> file.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +---------------------
>  1 file changed, 1 insertion(+), 21 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/include/mach/regs-clock.h b/arch/arm/mach-s3c64xx/include/mach/regs-clock.h
> index 4f44aac..46e64cc 100644
> --- a/arch/arm/mach-s3c64xx/include/mach/regs-clock.h
> +++ b/arch/arm/mach-s3c64xx/include/mach/regs-clock.h
> @@ -15,24 +15,4 @@
>  #ifndef __PLAT_REGS_CLOCK_H
>  #define __PLAT_REGS_CLOCK_H __FILE__
>  
> -/*
> - * FIXME: Remove remaining definitions
> - */
> -
> -#define S3C_CLKREG(x)		(S3C_VA_SYS + (x))
> -
> -#define S3C_PCLK_GATE		S3C_CLKREG(0x34)
> -#define S3C6410_CLK_SRC2	S3C_CLKREG(0x10C)
> -#define S3C_MEM_SYS_CFG		S3C_CLKREG(0x120)
> -
> -/* PCLK GATE Registers */
> -#define S3C_CLKCON_PCLK_UART3		(1<<4)
> -#define S3C_CLKCON_PCLK_UART2		(1<<3)
> -#define S3C_CLKCON_PCLK_UART1		(1<<2)
> -#define S3C_CLKCON_PCLK_UART0		(1<<1)
> -
> -/* MEM_SYS_CFG */
> -#define MEM_SYS_CFG_INDEP_CF		0x4000
> -#define MEM_SYS_CFG_EBI_FIX_PRI_CFCON	0x30
> -
> -#endif /* _PLAT_REGS_CLOCK_H */
> +/#endif /* _PLAT_REGS_CLOCK_H */

I don't know about the other changes, but that last line looks like an error.
Did you build anything that #includes this header file?


-- 
~Randy

  reply	other threads:[~2014-07-14 18:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 18:14 [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks Nicholas Krause
2014-07-14 18:23 ` Randy Dunlap [this message]
2014-07-14 18:40   ` Paul Bolle
2014-07-14 18:45     ` Randy Dunlap
2014-07-14 18:56       ` Nick Krause
2014-07-14 18:34 ` Randy Dunlap
2014-07-14 18:51 ` Arnd Bergmann
2014-07-14 21:43 ` Valdis.Kletnieks at vt.edu
2014-07-17  1:13   ` Nick Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4201E.3020708@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).