From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 4/5] regulator: tps65090: Set voltage for fixed regulators
Date: Wed, 30 Jul 2014 10:55:59 +0200 [thread overview]
Message-ID: <53D8B31F.6040404@collabora.co.uk> (raw)
In-Reply-To: <20140729173631.GX17528@sirena.org.uk>
On 07/29/2014 07:36 PM, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 06:28:58PM +0200, Javier Martinez Canillas wrote:
>
>> +#define tps65090_REG_VAR(_id, _sname, en_reg, _en_bits, _ops) \
>> + tps65090_REG_DESC(_id, _sname, en_reg, _en_bits, 0, 0, _ops)
>
> I'd expect this to describe a variable regulator when in fact it
> seems it describes a switch with no regulation. Better name please.
>
Yes, when writing the patch I thought of a switch as a non-fixed regulator whose
output voltage is variable and depend on its input supply voltage. That's why I
used VAR but I agree that is a bad name and I'll change it.
Thanks a lot and best regards,
Javier
next prev parent reply other threads:[~2014-07-30 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 16:28 [RFC 0/5] Get voltage from parent if not available on child Javier Martinez Canillas
2014-07-29 16:28 ` [RFC 1/5] regulator: core: Get voltage from parent if not available Javier Martinez Canillas
2014-07-29 18:26 ` Mark Brown
2014-07-30 9:01 ` Javier Martinez Canillas
2014-07-29 16:28 ` [RFC 2/5] regulator: core: Allow to get voltage count and list from parent Javier Martinez Canillas
2014-07-29 18:25 ` Mark Brown
2014-07-29 16:28 ` [RFC 3/5] regulator: core: Only apply constraints if available on list voltage Javier Martinez Canillas
2014-07-29 17:18 ` Mark Brown
2014-07-30 8:49 ` Javier Martinez Canillas
2014-07-30 10:42 ` Mark Brown
2014-07-29 16:28 ` [RFC 4/5] regulator: tps65090: Set voltage for fixed regulators Javier Martinez Canillas
2014-07-29 17:36 ` Mark Brown
2014-07-30 8:55 ` Javier Martinez Canillas [this message]
2014-07-29 16:28 ` [RFC 5/5] ARM: dts: Improve Peach Pit and Pi power scheme model Javier Martinez Canillas
2014-07-29 17:20 ` Mark Brown
2014-07-30 8:53 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D8B31F.6040404@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox