[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[Andreas Färber]

Hello,

This mini-series unbreaks booting on 5410 based ODROID-XU.

Since I do not have access to a TRM, the address is a guess based on 
5250 and 5410. Such a node was not present in the 3.14 downstream tree.

Regards,
Andreas

Andreas F?rber (3):
  Documentation: devicetree: Document exynos5410 PMU
  ARM: dts: exynos: Add PMU to Exynos5410
  ARM: EXYNOS: Add support for Exynos5410 PMU

 Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
 arch/arm/boot/dts/exynos5410.dtsi                     | 5 +++++
 arch/arm/mach-exynos/exynos.c                         | 1 +
 3 files changed, 7 insertions(+)

-- 
1.9.3

[PATCH 1/3] Documentation: devicetree: Document exynos5410 PMU

[Andreas Färber]

We will start using "samsung,exynos5410-pmu".

Signed-off-by: Andreas F?rber <afaerber@suse.de>
---
 Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
index 2a4ab046a8a1..fe14d8118093 100644
--- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
@@ -7,6 +7,7 @@ Properties:
 		   - "samsung,exynos4212-pmu" - for Exynos4212 SoC,
 		   - "samsung,exynos4412-pmu" - for Exynos4412 SoC,
 		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
+		   - "samsung,exynos5410-pmu" - for Exynos5410 SoC,
 		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
 		second value must be always "syscon".
 
-- 
1.9.3

[PATCH 2/3] ARM: dts: exynos: Add PMU to Exynos5410

[Andreas Färber]

Exynos initialization code now relies on obtaining the PMU address,
so prepare a PMU node for Exynos5410.

Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT")
Signed-off-by: Andreas F?rber <afaerber@suse.de>
---
 arch/arm/boot/dts/exynos5410.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
index 9d0b8cc1409c..790d4886d7b5 100644
--- a/arch/arm/boot/dts/exynos5410.dtsi
+++ b/arch/arm/boot/dts/exynos5410.dtsi
@@ -91,6 +91,11 @@
 			reg = <0x10000000 0x100>;
 		};
 
+		pmu_system_controller: system-controller at 10040000 {
+			compatible = "samsung,exynos5410-pmu", "syscon";
+			reg = <0x10040000 0x5000>;
+		};
+
 		mct: mct at 101C0000 {
 			compatible = "samsung,exynos4210-mct";
 			reg = <0x101C0000 0xB00>;
-- 
1.9.3

[PATCH 3/3] ARM: EXYNOS: Add support for Exynos5410 PMU

[Andreas Färber]

Exynos initialization code now relies on obtaining the PMU address,
so add the new 5410 value to the list of compatible string matches.
This unbreaks booting on 5410 based boards.

Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT")
Signed-off-by: Andreas F?rber <afaerber@suse.de>
---
 arch/arm/mach-exynos/exynos.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index df41bd190dfb..a83a312299a3 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -252,6 +252,7 @@ static const struct of_device_id exynos_dt_pmu_match[] = {
 	{ .compatible = "samsung,exynos4212-pmu" },
 	{ .compatible = "samsung,exynos4412-pmu" },
 	{ .compatible = "samsung,exynos5250-pmu" },
+	{ .compatible = "samsung,exynos5410-pmu" },
 	{ .compatible = "samsung,exynos5420-pmu" },
 	{ /*sentinel*/ },
 };
-- 
1.9.3

[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[Andreas Färber]

Am 27.07.2014 14:22, schrieb Andreas F?rber:
> Hello,
> 
> This mini-series unbreaks booting on 5410 based ODROID-XU.
> 
> Since I do not have access to a TRM, the address is a guess based on 
> 5250 and 5410. Such a node was not present in the 3.14 downstream tree.

s/5410/5420/

> 
> Regards,
> Andreas
> 
> Andreas F?rber (3):
>   Documentation: devicetree: Document exynos5410 PMU
>   ARM: dts: exynos: Add PMU to Exynos5410
>   ARM: EXYNOS: Add support for Exynos5410 PMU
> 
>  Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
>  arch/arm/boot/dts/exynos5410.dtsi                     | 5 +++++
>  arch/arm/mach-exynos/exynos.c                         | 1 +
>  3 files changed, 7 insertions(+)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[Kukjin Kim]

Andreas F?rber wrote:
> 
> Am 27.07.2014 14:22, schrieb Andreas F?rber:
> > Hello,
> >
> > This mini-series unbreaks booting on 5410 based ODROID-XU.
> >
> > Since I do not have access to a TRM, the address is a guess based on
> > 5250 and 5410. Such a node was not present in the 3.14 downstream tree.
> 
> s/5410/5420/
> 
OK.

> >
> > Regards,
> > Andreas
> >
> > Andreas F?rber (3):
> >   Documentation: devicetree: Document exynos5410 PMU
> >   ARM: dts: exynos: Add PMU to Exynos5410
> >   ARM: EXYNOS: Add support for Exynos5410 PMU
> >
> >  Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
> >  arch/arm/boot/dts/exynos5410.dtsi                     | 5 +++++
> >  arch/arm/mach-exynos/exynos.c                         | 1 +
> >  3 files changed, 7 insertions(+)
> 
Andreas, thanks.

I'll apply this whole series.

- Kukjin

[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[Olof Johansson]

Hi,

On Sun, Jul 27, 2014 at 5:39 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Andreas F?rber wrote:
>>
>> Am 27.07.2014 14:22, schrieb Andreas F?rber:
>> > Hello,
>> >
>> > This mini-series unbreaks booting on 5410 based ODROID-XU.
>> >
>> > Since I do not have access to a TRM, the address is a guess based on
>> > 5250 and 5410. Such a node was not present in the 3.14 downstream tree.
>>
>> s/5410/5420/
>>
> OK.
>
>> >
>> > Regards,
>> > Andreas
>> >
>> > Andreas F?rber (3):
>> >   Documentation: devicetree: Document exynos5410 PMU
>> >   ARM: dts: exynos: Add PMU to Exynos5410
>> >   ARM: EXYNOS: Add support for Exynos5410 PMU
>> >
>> >  Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
>> >  arch/arm/boot/dts/exynos5410.dtsi                     | 5 +++++
>> >  arch/arm/mach-exynos/exynos.c                         | 1 +
>> >  3 files changed, 7 insertions(+)
>>
> Andreas, thanks.
>
> I'll apply this whole series.

We're getting close to the merge window. I'd prefer not to have to
start reverting samsung code to recover from these regressions, so
please send this up very soon.


-Olof

[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[Kukjin Kim]

Olof Johansson wrote:
> 
> Hi,
> 
Hi Olof,

> On Sun, Jul 27, 2014 at 5:39 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Andreas F?rber wrote:
> >>
> >> Am 27.07.2014 14:22, schrieb Andreas F?rber:
> >> > Hello,
> >> >
> >> > This mini-series unbreaks booting on 5410 based ODROID-XU.
> >> >
> >> > Since I do not have access to a TRM, the address is a guess based on
> >> > 5250 and 5410. Such a node was not present in the 3.14 downstream tree.
> >>
> >> s/5410/5420/
> >>
> > OK.
> >
> >> >
> >> > Regards,
> >> > Andreas
> >> >
> >> > Andreas F?rber (3):
> >> >   Documentation: devicetree: Document exynos5410 PMU
> >> >   ARM: dts: exynos: Add PMU to Exynos5410
> >> >   ARM: EXYNOS: Add support for Exynos5410 PMU
> >> >
> >> >  Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
> >> >  arch/arm/boot/dts/exynos5410.dtsi                     | 5 +++++
> >> >  arch/arm/mach-exynos/exynos.c                         | 1 +
> >> >  3 files changed, 7 insertions(+)
> >>
> > Andreas, thanks.
> >
> > I'll apply this whole series.
> 
> We're getting close to the merge window. I'd prefer not to have to
> start reverting samsung code to recover from these regressions, so
> please send this up very soon.
> 
Thanks for your gentle reminder.

BTW I'm waiting for exynos5250-spring support from Andreas and I'd like to get
confirmation about that from Doug. And I'm looking at s2r related patches now.

OK, I will send out current samsung tree tonight in my time anyway.

- Kukjin

[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[Andreas Färber]

Hi Kukjin,

Am 31.07.2014 03:10, schrieb Kukjin Kim:
> Olof Johansson wrote:
>>
>> Hi,
>>
> Hi Olof,
> 
>> On Sun, Jul 27, 2014 at 5:39 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>>> Andreas F?rber wrote:
>>>>
>>>> Am 27.07.2014 14:22, schrieb Andreas F?rber:
>>>>> Hello,
>>>>>
>>>>> This mini-series unbreaks booting on 5410 based ODROID-XU.
>>>>>
>>>>> Since I do not have access to a TRM, the address is a guess based on
>>>>> 5250 and 5410. Such a node was not present in the 3.14 downstream tree.
>>>>
>>>> s/5410/5420/
>>>>
>>> OK.
>>>
>>>>>
>>>>> Regards,
>>>>> Andreas
>>>>>
>>>>> Andreas F?rber (3):
>>>>>   Documentation: devicetree: Document exynos5410 PMU
>>>>>   ARM: dts: exynos: Add PMU to Exynos5410
>>>>>   ARM: EXYNOS: Add support for Exynos5410 PMU
>>>>>
>>>>>  Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
>>>>>  arch/arm/boot/dts/exynos5410.dtsi                     | 5 +++++
>>>>>  arch/arm/mach-exynos/exynos.c                         | 1 +
>>>>>  3 files changed, 7 insertions(+)
>>>>
>>> Andreas, thanks.
>>>
>>> I'll apply this whole series.
>>
>> We're getting close to the merge window. I'd prefer not to have to
>> start reverting samsung code to recover from these regressions, so
>> please send this up very soon.
>>
> Thanks for your gentle reminder.
> 
> BTW I'm waiting for exynos5250-spring support from Andreas and I'd like to get
> confirmation about that from Doug. And I'm looking at s2r related patches now.
> 
> OK, I will send out current samsung tree tonight in my time anyway.

That would be kind.

Patches 2-3 in spring v3 should be non-functional snow refactorings for
you to consider, but untested by me; patch 1 you could skip if you
modify patch 2, if necessary. As for patch 4, you can see from my
spring-next branch [1] how I am successfully testing it with a TEST_ONLY
patch: For simplefb usage I comment out the /dp-controller node to avoid
drm/exynos detection (not enabling the driver in the user's .config
would be an alternative); when I run into issues with the drm during
testing, I can usually ssh in via USB ethernet/wifi.

In the dmesg for drm/exynos bridge series testing [2] (which I guess is
not gonna hit 3.17 any more?) I noticed that the USB3503 /usb-hub node
new in v3 is not working yet (complains about lack of #gpio-cells, I
guess for my reset-gpios property), not sure how to fix, so we/you could
probably just drop that node - preparing to test that now.

As for the rest of patch 4, it's a new DT, so we could fix up any
remaining bugs during 3.17 RC cycle, if it looks sane to you guys now. I
had replied to two series - namely cpufreq [3] and dwmmc [4] - where
merge conflicts might arise. Let me know if you need a respin for anything.

Regards,
Andreas

[1] https://github.com/afaerber/linux/commits/spring-next
[2]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34927.html
[3]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34807.html
[4]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34898.html

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

[PATCH 0/3] ARM: EXYNOS: Fix Exynos5410 boot

[Andreas Färber]

Am 31.07.2014 05:59, schrieb Andreas F?rber:
> Hi Kukjin,
> 
> Am 31.07.2014 03:10, schrieb Kukjin Kim:
>> Olof Johansson wrote:
>>>
>>> Hi,
>>>
>> Hi Olof,
>>
>>> On Sun, Jul 27, 2014 at 5:39 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>>>> Andreas F?rber wrote:
>>>>>
>>>>> Am 27.07.2014 14:22, schrieb Andreas F?rber:
>>>>>> Hello,
>>>>>>
>>>>>> This mini-series unbreaks booting on 5410 based ODROID-XU.
>>>>>>
>>>>>> Since I do not have access to a TRM, the address is a guess based on
>>>>>> 5250 and 5410. Such a node was not present in the 3.14 downstream tree.
>>>>>
>>>>> s/5410/5420/
>>>>>
>>>> OK.
>>>>
>>>>>>
>>>>>> Regards,
>>>>>> Andreas
>>>>>>
>>>>>> Andreas F?rber (3):
>>>>>>   Documentation: devicetree: Document exynos5410 PMU
>>>>>>   ARM: dts: exynos: Add PMU to Exynos5410
>>>>>>   ARM: EXYNOS: Add support for Exynos5410 PMU
>>>>>>
>>>>>>  Documentation/devicetree/bindings/arm/samsung/pmu.txt | 1 +
>>>>>>  arch/arm/boot/dts/exynos5410.dtsi                     | 5 +++++
>>>>>>  arch/arm/mach-exynos/exynos.c                         | 1 +
>>>>>>  3 files changed, 7 insertions(+)
>>>>>
>>>> Andreas, thanks.
>>>>
>>>> I'll apply this whole series.
>>>
>>> We're getting close to the merge window. I'd prefer not to have to
>>> start reverting samsung code to recover from these regressions, so
>>> please send this up very soon.
>>>
>> Thanks for your gentle reminder.
>>
>> BTW I'm waiting for exynos5250-spring support from Andreas and I'd like to get
>> confirmation about that from Doug. And I'm looking at s2r related patches now.
>>
>> OK, I will send out current samsung tree tonight in my time anyway.
> 
> That would be kind.
> 
> Patches 2-3 in spring v3 should be non-functional snow refactorings for
> you to consider, but untested by me; patch 1 you could skip if you
> modify patch 2, if necessary. As for patch 4, you can see from my
> spring-next branch [1] how I am successfully testing it with a TEST_ONLY
> patch: For simplefb usage I comment out the /dp-controller node to avoid
> drm/exynos detection (not enabling the driver in the user's .config
> would be an alternative); when I run into issues with the drm during
> testing, I can usually ssh in via USB ethernet/wifi.
> 
> In the dmesg for drm/exynos bridge series testing [2] (which I guess is
> not gonna hit 3.17 any more?) I noticed that the USB3503 /usb-hub node
> new in v3 is not working yet (complains about lack of #gpio-cells, I
> guess for my reset-gpios property), not sure how to fix, so we/you could
> probably just drop that node - preparing to test that now.

Misread that message, it does not seem to be fatal. I do see the device
as /sys/devices/usb-hub.

[    0.618757] of_get_named_gpiod_flags: can't parse gpios property of
node '/usb-hub[0]'
[    0.618763] of_get_named_gpiod_flags: can't parse gpios property of
node '/usb-hub[0]'
[    0.618777] /usb-hub: could not get #gpio-cells for
/pinctrl at 13400000/hsic-reset
[    0.620743] of_get_named_gpiod_flags: can't parse gpios property of
node '/usb-hub[0]'
[    0.629797] usb3503 usb-hub: switched to HUB mode
[    0.631752] usb3503 usb-hub: usb3503_probe: probed in hub mode

Andreas

> As for the rest of patch 4, it's a new DT, so we could fix up any
> remaining bugs during 3.17 RC cycle, if it looks sane to you guys now. I
> had replied to two series - namely cpufreq [3] and dwmmc [4] - where
> merge conflicts might arise. Let me know if you need a respin for anything.
> 
> Regards,
> Andreas
> 
> [1] https://github.com/afaerber/linux/commits/spring-next
> [2]
> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34927.html
> [3]
> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34807.html
> [4]
> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34898.html
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg