linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: LLVMLinux: Calculate current_thread_info from current_stack_pointer
Date: Thu, 31 Jul 2014 07:31:30 +0200	[thread overview]
Message-ID: <53D9D4B2.8070008@suse.de> (raw)
In-Reply-To: <1406764649-20326-4-git-send-email-behanw@converseincode.com>

Hi,

Am 31.07.2014 01:57, schrieb behanw at converseincode.com:
> From: Behan Webster <behanw@converseincode.com>
> 
> Use the global current_stack_pointer to get the value of the stack pointer.
> This change supports being able to compile the kernel with both gcc and clang.
> 
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Signed-off-by: Mark Charlebois <charlebm@gmail.com>
> Reviewed-by: Jan-Simon M??ller <dl9pf@gmx.de>

Something went wrong with ? encoding here and in 2/4.

> ---
>  arch/arm64/include/asm/thread_info.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/thread_info.h b/arch/arm64/include/asm/thread_info.h
> index e6b6094..c2432d2 100644
> --- a/arch/arm64/include/asm/thread_info.h
> +++ b/arch/arm64/include/asm/thread_info.h
> @@ -80,8 +80,8 @@ static inline struct thread_info *current_thread_info(void) __attribute_const__;
>  
>  static inline struct thread_info *current_thread_info(void)
>  {
> -	register unsigned long sp asm ("sp");
> -	return (struct thread_info *)(sp & ~(THREAD_SIZE - 1));
> +	return (struct thread_info *) \

This is not a macro, so \ seems superfluous.

Looks okay otherwise.

Regards,
Andreas

> +		(current_stack_pointer & ~(THREAD_SIZE - 1));
>  }
>  
>  #define thread_saved_pc(tsk)	\

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

  reply	other threads:[~2014-07-31  5:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30 23:57 [PATCH 0/4] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM behanw at converseincode.com
2014-07-30 23:57 ` [PATCH 1/4] arm64: LLVMLinux: Add current_stack_pointer() for arm64 behanw at converseincode.com
2014-07-30 23:57 ` [PATCH 2/4] arm64: LLVMLinux: Use current_stack_pointer in save_stack_trace_tsk behanw at converseincode.com
2014-07-30 23:57 ` [PATCH 3/4] arm64: LLVMLinux: Calculate current_thread_info from current_stack_pointer behanw at converseincode.com
2014-07-31  5:31   ` Andreas Färber [this message]
2014-07-31 16:04     ` Behan Webster
2014-07-30 23:57 ` [PATCH 4/4] arm64: LLVMLinux: Use current_stack_pointer in kernel/traps.c behanw at converseincode.com
2014-07-31  0:11 ` [PATCH 0/4] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM Olof Johansson
2014-07-31 10:33 ` Will Deacon
2014-07-31 15:39   ` Olof Johansson
2014-07-31 15:48     ` Will Deacon
2014-07-31 15:52       ` Olof Johansson
2014-08-01  4:11   ` Behan Webster
2014-08-26 14:16     ` Will Deacon
2014-08-27  4:26       ` Behan Webster
2014-08-27  4:29       ` [PATCH V2 0/6] " behanw at converseincode.com
2014-08-27  4:29         ` [PATCH V2 1/6] arm64: LLVMLinux: Add current_stack_pointer() for arm64 behanw at converseincode.com
2014-08-27  4:29         ` [PATCH V2 2/6] arm64: LLVMLinux: Use current_stack_pointer in save_stack_trace_tsk behanw at converseincode.com
2014-08-27  4:29         ` [PATCH V2 3/6] arm64: LLVMLinux: Calculate current_thread_info from current_stack_pointer behanw at converseincode.com
2014-08-27  4:29         ` [PATCH V2 4/6] arm64: LLVMLinux: Use current_stack_pointer in kernel/traps.c behanw at converseincode.com
2014-08-27  4:29         ` [PATCH V2 5/6] arm64: LLVMLinux: Use global stack register variable for aarch64 behanw at converseincode.com
2014-08-27  4:29         ` [PATCH V2 6/6] arm64: LLVMLinux: Use global stack pointer in return_address() behanw at converseincode.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D9D4B2.8070008@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).